Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis Revamp #1624

Merged
merged 30 commits into from
Dec 30, 2018
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
c236956
Fix and enable multi-threaded analysis
uklotzde Apr 18, 2018
3b0c4d0
Merge branch 'master' of git@github.com:mixxxdj/mixxx.git into lp1737…
uklotzde Nov 22, 2018
9449ed9
Rename constant
uklotzde Nov 21, 2018
7290aba
Round analyzer progress percentage
uklotzde Nov 21, 2018
d1497ac
Use type-safe signal/slot connections
uklotzde Nov 21, 2018
ca2e910
Replace static factory function with subclass + default constructor
uklotzde Nov 22, 2018
eb8e9ac
Add warning for reading atomic control values only once
uklotzde Nov 22, 2018
6961c76
Replace ControlValue with new, lock-free MpscFifo class
uklotzde Nov 22, 2018
266884e
Update comments about analysis parameterization
uklotzde Nov 22, 2018
41925b6
Revert constexpr
uklotzde Nov 22, 2018
4164736
Merge branch 'master' of git@github.com:mixxxdj/mixxx.git into lp1737…
uklotzde Dec 17, 2018
05d7336
Merge branch 'master' of git@github.com:mixxxdj/mixxx.git into lp1737…
uklotzde Dec 24, 2018
965d52b
Replace QAtomicInteger with QAtomicInt
uklotzde Dec 24, 2018
460670d
Register meta-types only once
uklotzde Dec 24, 2018
5fb877e
Add a TODO comment for scheduling updates with the vsync timer
uklotzde Dec 24, 2018
738ae85
Replace conditional else branch with early exit
uklotzde Dec 24, 2018
45d05c1
Fix release of writer lock on ControlValue
uklotzde Dec 25, 2018
aadcca4
Fix use of QAtomicInt for Qt5.2
daschuer Dec 23, 2018
7bf1157
Merge pull request #9 from daschuer/lp1737537_analysis_revamp
uklotzde Dec 26, 2018
b96dc8d
Re-add slot count unconditionally
uklotzde Dec 26, 2018
0202f78
Start timer when executing the worker thread
uklotzde Dec 26, 2018
fdf8ee2
Use a bitfield for selecting and enabling analyzers
uklotzde Dec 26, 2018
9578bf6
Rename functions: "receive<Event>()" -> "on<Event>()"
uklotzde Dec 26, 2018
4ba1f39
Don't store a plain pointer as member
uklotzde Dec 26, 2018
78cef8f
Fix comments and add debug logs
uklotzde Dec 28, 2018
dcf6301
Stop worker threads before exiting
uklotzde Dec 28, 2018
d7bc6fb
Prevent a deadlock when exiting main()
uklotzde Dec 28, 2018
11a27cf
Merge branch 'master' of git@github.com:mixxxdj/mixxx.git into lp1737…
uklotzde Dec 28, 2018
96136a3
Reword and amend comment
uklotzde Dec 28, 2018
78d2db8
Fix use after free error
uklotzde Dec 29, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/mixxx.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -728,6 +728,10 @@ void MixxxMainWindow::finalize() {
// Report the total time we have been running.
m_runtime_timer.elapsed(true);
StatsManager::destroy();

// NOTE(uklotzde, 2018-12-28): Finally destroy the singleton instance
// to prevent a when while exiting the main() function!
Be-ing marked this conversation as resolved.
Show resolved Hide resolved
GlobalTrackCache::destroyInstance();
}

bool MixxxMainWindow::initializeDatabase() {
Expand Down