Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues identified by clazy. #1869

Merged
merged 2 commits into from
Oct 28, 2018
Merged

Fix some issues identified by clazy. #1869

merged 2 commits into from
Oct 28, 2018

Conversation

rryan
Copy link
Member

@rryan rryan commented Oct 26, 2018

No description provided.

daschuer
daschuer reviewed Oct 27, 2018
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only some minor comments.

src/control/controlobjectscript.cpp Outdated Show resolved Hide resolved
src/engine/cachingreader.cpp Outdated Show resolved Hide resolved
@daschuer
Copy link
Member

Thank you for this piece of busy work.

@ywwg
Copy link
Member

ywwg commented Oct 28, 2018

sort of related to this kind of cleanup, have we thought about turning on -WError?

@rryan
Copy link
Member Author

rryan commented Oct 28, 2018

Thanks for the review!

@rryan rryan merged commit 3da63b2 into mixxxdj:master Oct 28, 2018
@rryan
Copy link
Member Author

rryan commented Oct 28, 2018

Oops, this broke the Xenial and Trusty PPA builds because QMap::keyBegin was added in 5.6 and QVector::removeOne was added in 5.4. The Travis build uses Trusty, and I didn't notice it broke -- my bad :(. I'll fix it.

@rryan
Copy link
Member Author

rryan commented Oct 28, 2018

sort of related to this kind of cleanup, have we thought about turning on -WError?

I'd be in favor -- note that none of these issues are identified by clang or gcc though, they're from clazy.

@Be-ing
Copy link
Contributor

Be-ing commented Oct 28, 2018

We never reached a consensus about supporting Ubuntu 16.04 or older with Mixxx 2.3. IMO there is no need to revert those changes.

@rryan
Copy link
Member Author

rryan commented Oct 28, 2018 •
edited
Loading

We never reached a consensus about supporting Ubuntu 16.04 or older with Mixxx 2.3. IMO there is no need to revert those changes.

Right, until we do :). I agree that Bionic / Qt 5.9 (in general, the latest LTS) should be our new minimum requirement.

@rryan
Copy link
Member Author

rryan commented Oct 28, 2018

Travis is unfortunately stuck in a time-warp and doesn't even support Xenial yet. I don't understand their priorities.

@Be-ing
Copy link
Contributor

Be-ing commented Oct 28, 2018

wat... maybe we should use a different CI service, at least for Linux...

@rryan
Copy link
Member Author

rryan commented Oct 28, 2018

wat... maybe we should use a different CI service, at least for Linux...

Yea, AppVeyor supports Bionic.

@Be-ing
Copy link
Contributor

Be-ing commented Oct 28, 2018

I'd be in favor of moving Linux CI to AppVeyor.

rryan added a commit that referenced this pull request Oct 28, 2018
@rryan
Fix breakage from PR #1869 due to using Qt 5 features not supported o…
db7fe92 
…n Trusty/Xenial.

Also fixes a potential race condition in MusicBrainzClient/AcoustidClient where
m_requests temporarily contains deleted pointers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywwg ywwg ywwg left review comments

@daschuer daschuer daschuer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rryan @daschuer @ywwg @Be-ing