Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pitchbend direction fix lp1770745 #1906

Merged
merged 8 commits into from
Jan 4, 2019
Merged

Pitchbend direction fix lp1770745 #1906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
14b39b6
fix boolean interpretations of button COs. Fix coding style.
daschuer Nov 17, 2018
93badfb
fix temp rate scaling, rename to m_tempRateRatio
daschuer Nov 17, 2018
aa2a8c2
Fix going backwards, holding pitch bend buttons
daschuer Nov 17, 2018
10bbbce
don't override user setting m_dTemporaryRateChangeCoarse in linear mode
daschuer Nov 17, 2018
19c44c6
Added test and fix to require two process calls to adopt pitch bend
daschuer Nov 18, 2018
aa12950
removed unused m_eRampBackMode
daschuer Nov 18, 2018
ff99c05
separate linear from stepping code.
daschuer Nov 20, 2018
6351176
Merge remote-tracking branch 'upstream/2.1' into pitchbend
daschuer Dec 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/engine/enginebuffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,7 @@ class EngineBuffer : public EngineObject {
FRIEND_TEST(EngineBufferTest, ResetPitchAdjustUsesLinear);
FRIEND_TEST(EngineBufferTest, VinylScalerRampZero);
FRIEND_TEST(EngineBufferTest, ReadFadeOut);
FRIEND_TEST(EngineBufferTest, RateTempTest);
EngineBufferScale* m_pScaleVinyl;
// The keylock engine is configurable, so it could flip flop between
// ScaleST and ScaleRB during a single callback.
Expand Down
Loading