Fix build on Ubuntu caused by incorrect order of libraries #1926

ninomp · 2018-11-29T23:00:18Z

This fixes https://bugs.launchpad.net/mixxx/+bug/1804411

The solution is to specify -ldl after -lvamp-hostsdk. However, I couldn't find a way to remove the first -ldl, so -ldl is currently duplicated.

This fixes https://bugs.launchpad.net/mixxx/+bug/1804411.

ninomp · 2018-11-30T00:12:33Z

Should I squash these two commits into one?

daschuer · 2018-11-30T07:10:17Z

I don't mind in this case. Normally you should not rewrite the history in a pending PR.

daschuer · 2018-11-30T07:14:59Z

Is the 2.1 branch also effected?
If yes, we should reabse (and squash) it to it.

daschuer · 2018-11-30T07:23:12Z

The first dl is added here:

mixxx/build/features.py

Line 363 in 061073f

if build.platform_is_linux:

Can we remove it?

Be-ing · 2018-11-30T07:25:34Z

Is the 2.1 branch also effected?

No, this bug was caused by #1841 which was merged to master.

ninomp · 2018-12-18T01:09:25Z

@daschuer Hmm, if we remove conf.CheckLib(['dl', 'libdl'])' from configure(), scons will no longer check if this library is available/installed during its configuration step.

ninomp · 2018-12-18T01:25:15Z

I tested these changes on Linux Mint 18.3 and Fedora 29 and it seems that duplicate -ldl isn't causing any problems.

daschuer · 2018-12-24T12:21:04Z

Please check if the original issue was caused by a double -lvamp-hostsdk
fixed in:
#1959

daschuer

conf.CheckLib(['dl', 'libdl']) already adds -ldl.
The double -ldl should be fixed before merge.

nopeppermint · 2018-12-24T15:19:18Z

I can confirm that this fix error https://bugs.launchpad.net/mixxx/+bug/1804411 on Linux Mint 19 x64

But if I remove the line suggested by @daschuer in #1959 I get the following error:

ValueError: list.remove(x): x not in list:
  File "/home/stefan/mixxx_develop/mixxx/SConstruct", line 101:
    duplicate=0, exports=['build'])
  File "/usr/lib/scons/SCons/Script/SConscript.py", line 614:
    return method(*args, **kw)
  File "/usr/lib/scons/SCons/Script/SConscript.py", line 551:
    return _SConscript(self.fs, *files, **subst_kw)
  File "/usr/lib/scons/SCons/Script/SConscript.py", line 256:
    call_stack[-1].globals)
  File "/home/stefan/mixxx_develop/mixxx/vamp-plugins/SConscript", line 62:
    env['LIBS'].remove('vamp-hostsdk')

but If I remove env['LIBS'].remove('vamp-hostsdk') on line 62 in the file /mixxx/vamp-plugins/SConscript I get other errors:

/home/stefan/mixxx_develop/mixxx/src/analyzer/vamp/vamppluginadapter.cpp:149: Warnung: undefinierter Verweis auf »_VampHost::Vamp::HostExt::PluginLoader::getInstance()«
lin64_build/libmixxx.a(vamppluginadapter.o): In Funktion »mixxx::VampPluginAdapter::listPlugins[abi:cxx11]()«:
/home/stefan/mixxx_develop/mixxx/src/analyzer/vamp/vamppluginadapter.cpp:184: Warnung: undefinierter Verweis auf »_VampHost::Vamp::HostExt::PluginLoader::listPlugins[abi:cxx11]()«
lin64_build/libmixxx.a(vamppluginadapter.o): In Funktion »mixxx::VampPluginAdapter::composePluginKey(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)«:
/home/stefan/mixxx_develop/mixxx/src/analyzer/vamp/vamppluginadapter.cpp:198: Warnung: undefinierter Verweis auf »_VampHost::Vamp::HostExt::PluginLoader::composePluginKey(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)«
lin64_build/libmixxx.a(vamppluginadapter.o): In Funktion »mixxx::VampPluginAdapter::loadPlugin(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, float, int)«:
/home/stefan/mixxx_develop/mixxx/src/analyzer/vamp/vamppluginadapter.cpp:165: Warnung: undefinierter Verweis auf »_VampHost::Vamp::HostExt::PluginLoader::loadPlugin(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, float, int)«
lin64_build/libmixxx.a(vampanalyzer.o): In Funktion »VampAnalyzer::Init(QString, QString, int, int, bool)«:
/home/stefan/mixxx_develop/mixxx/src/analyzer/vamp/vampanalyzer.cpp:60: Warnung: undefinierter Verweis auf »_VampHost::Vamp::PluginHostAdapter::getPluginPath[abi:cxx11]()«
lin64_build/libmixxx.a(vampanalyzer.o): In Funktion »VampAnalyzer::GetInitFramesVector()«:
/home/stefan/mixxx_develop/mixxx/src/analyzer/vamp/vampanalyzer.cpp:247: Warnung: undefinierter Verweis auf »_VampHost::Vamp::RealTime::realTime2Frame(_VampHost::Vamp::RealTime const&, unsigned int)«
lin64_build/libmixxx.a(vampanalyzer.o): In Funktion »VampAnalyzer::GetEndFramesVector()«:
/home/stefan/mixxx_develop/mixxx/lib/vamp/vamp-sdk/RealTime.h:92: Warnung: undefinierter Verweis auf »_VampHost::Vamp::RealTime::RealTime(int, int)«
lin64_build/libmixxx.a(vampanalyzer.o): In Funktion »VampAnalyzer::GetEndFramesVector()«:
/home/stefan/mixxx_develop/mixxx/src/analyzer/vamp/vampanalyzer.cpp:263: Warnung: undefinierter Verweis auf »_VampHost::Vamp::RealTime::realTime2Frame(_VampHost::Vamp::RealTime const&, unsigned int)«
lin64_build/libmixxx.a(vampanalyzer.o): In Funktion »VampAnalyzer::Process(float const*, int)«:
/home/stefan/mixxx_develop/mixxx/src/analyzer/vamp/vampanalyzer.cpp:175: Warnung: undefinierter Verweis auf »_VampHost::Vamp::RealTime::frame2RealTime(long, unsigned int)«
collect2: error: ld returned 1 exit status
scons: *** [lin64_build/mixxx] Error 1
scons: building terminated because of errors.

so there might be more to do..

nopeppermint · 2018-12-24T16:53:10Z

thanks!
now compiling current master with this pr on top is working again on Linux Mint 19 x64

ninomp · 2018-12-24T17:01:47Z

OK I have managed to resolve duplicates. They were caused by having two VAMP SDKs: one installed on system and the other bundled with Mixxx. I have tested this only on my Linux Mint 18.3 system, on which Mixxx is always taking the bundled VAMP SDK. Can you test this on Linux Mint 19 as well as other distros?

ninomp · 2018-12-24T17:04:37Z

@nopeppermint Glad to hear it 😄

daschuer · 2018-12-25T07:10:47Z

Greate, no it is fine, Thank you. I think just need to comment why we need a special treatment here.

daschuer · 2018-12-25T07:21:24Z

build/features.py

-            conf.CheckLib(['dl', 'libdl'])
+            # Note: We are adding -ldl to LIBS in sources(), so
+            # don't add it now in order to prevent duplication.
+            conf.CheckLib(['dl', 'libdl'], autoadd=False)


# we cant add it here,because it need to be added after vamp-hostsdk. See https://bugs.launchpad.net/mixxx/+bug/1804411

daschuer · 2018-12-25T07:27:33Z

build/features.py

@@ -383,7 +387,12 @@ def sources(self, build):
            env.SConscript(env.File('SConscript', vamp_dir))

            build.env.Append(LIBPATH=self.INTERNAL_VAMP_PATH)
-            build.env.Append(LIBS=['vamp-hostsdk'])
+
+        build.env.Append(LIBS=['vamp-hostsdk'])


Something like this:
# we add this here unconditionally because it is expected by vamp-plugins/SConscript which does further adjustments

daschuer · 2018-12-25T20:38:36Z

Thank you, for your patience. LGTM.

ninomp · 2018-12-25T21:38:49Z

Thank you for merging.

ninomp added 2 commits November 29, 2018 23:52

Fix build on Ubuntu caused by incorrect order of libraries

71c6dce

This fixes https://bugs.launchpad.net/mixxx/+bug/1804411.

Fix Windows build

061073f

daschuer mentioned this pull request Dec 24, 2018

fix double -lvamp-hostsdk #1959

Closed

daschuer requested changes Dec 24, 2018

View reviewed changes

Remove duplicate -lvamp-hostsdk and -ldl from LIBS

585482e

daschuer reviewed Dec 25, 2018

View reviewed changes

Improve comment

e8c138f

daschuer approved these changes Dec 25, 2018

View reviewed changes

daschuer merged commit 0c9845b into mixxxdj:master Dec 25, 2018

ninomp deleted the ubuntubuildfix branch December 25, 2018 21:38

mixxxbot mentioned this pull request Aug 23, 2022

undefined reference to symbol 'dlclose@@GLIBC_2.2.5' #9525

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix build on Ubuntu caused by incorrect order of libraries #1926

Fix build on Ubuntu caused by incorrect order of libraries #1926

ninomp commented Nov 29, 2018 •

edited

Loading

ninomp commented Nov 30, 2018

daschuer commented Nov 30, 2018

daschuer commented Nov 30, 2018

daschuer commented Nov 30, 2018

Be-ing commented Nov 30, 2018

ninomp commented Dec 18, 2018

ninomp commented Dec 18, 2018 •

edited

Loading

daschuer commented Dec 24, 2018

daschuer left a comment •

edited

Loading

nopeppermint commented Dec 24, 2018

nopeppermint commented Dec 24, 2018

ninomp commented Dec 24, 2018

ninomp commented Dec 24, 2018

daschuer commented Dec 25, 2018

daschuer Dec 25, 2018 •

edited

Loading

daschuer Dec 25, 2018

daschuer commented Dec 25, 2018

ninomp commented Dec 25, 2018

Fix build on Ubuntu caused by incorrect order of libraries #1926

Fix build on Ubuntu caused by incorrect order of libraries #1926

Conversation

ninomp commented Nov 29, 2018 • edited Loading

ninomp commented Nov 30, 2018

daschuer commented Nov 30, 2018

daschuer commented Nov 30, 2018

daschuer commented Nov 30, 2018

Be-ing commented Nov 30, 2018

ninomp commented Dec 18, 2018

ninomp commented Dec 18, 2018 • edited Loading

daschuer commented Dec 24, 2018

daschuer left a comment • edited Loading

Choose a reason for hiding this comment

nopeppermint commented Dec 24, 2018

nopeppermint commented Dec 24, 2018

ninomp commented Dec 24, 2018

ninomp commented Dec 24, 2018

daschuer commented Dec 25, 2018

daschuer Dec 25, 2018 • edited Loading

Choose a reason for hiding this comment

daschuer Dec 25, 2018

Choose a reason for hiding this comment

daschuer commented Dec 25, 2018

ninomp commented Dec 25, 2018

ninomp commented Nov 29, 2018 •

edited

Loading

ninomp commented Dec 18, 2018 •

edited

Loading

daschuer left a comment •

edited

Loading

daschuer Dec 25, 2018 •

edited

Loading