-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library features: move buttons close to tree view #1934
Conversation
This makes sense on its own. |
Yeah, I understand but IMO it's better for new users (and online reviewers:)
Regarding the performance and UX issues we found (and will find) I'm somehow doubtful the lib redesign will be available to regular users before 2.5 Even if it'll be in 2.4 we'd have about one more year with the current lib design. |
I am still eager to merge the redesign branch to 2.3. I think the best option is to just exclude the CPU consuming features. This here is a nice idea, but the button position where not changed for many years and there is no need to change this for the remaining year. |
I agree with @ronso0. The library redesign branch in its current state will not be ready for 2.3. The UX is improved by these changes 👍 I would like to see this in 2.2. |
Yes, It need to be improved. Maybe we miss the 2.3 release date.
For 2.2? This is a master PR, for 2.3 currently. . |
After I noticed we'll still have a while until the lib-redesign, I'd target this at 2.2 if we reach a concensus to merge this asap. |
LGTM. I'm in favor of merging this to master now. |
Whoops, this was merged too early as I didn't mark it WIP. I'll open a foolow-up asap. |
I feel it makes more sense to have the library feature buttons (Enable AutoDJ, Analyze, Start Recording) closer to the currently focused area when coming from the tree pane.
I moved those buttons to th left to shorten the mouse cursor distance, especially on HD screens.
Before, the library feature buttons where at the far right above the tracks table.
Was there any strong reason to put them there? I'd say I'm a power user, and every time I use the Hidden or Missing feature I search the buttons. Maybe I'm just a slow learner...
I think it's worth using this fix for now (2.3, 2.4?). This might irritate users who got used to the current layout, but it's an improvement for all users. And it feels like a transition to the much better solution in the lib-redesing branch.