Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library features: move buttons close to tree view #1934

Merged
merged 2 commits into from
Dec 27, 2018

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Dec 6, 2018

lib-ux-impro
lib-ux-impro2

I feel it makes more sense to have the library feature buttons (Enable AutoDJ, Analyze, Start Recording) closer to the currently focused area when coming from the tree pane.
I moved those buttons to th left to shorten the mouse cursor distance, especially on HD screens.

Before, the library feature buttons where at the far right above the tracks table.
Was there any strong reason to put them there? I'd say I'm a power user, and every time I use the Hidden or Missing feature I search the buttons. Maybe I'm just a slow learner...

I think it's worth using this fix for now (2.3, 2.4?). This might irritate users who got used to the current layout, but it's an improvement for all users. And it feels like a transition to the much better solution in the lib-redesing branch.

@daschuer
Copy link
Member

daschuer commented Dec 7, 2018

This makes sense on its own.
On the other hand experienced users will find a gap where the buttons originally where. We will merge the library redesign branch soon, so we need to consider this as well and "disturb" the users workflow only once.

@ronso0
Copy link
Member Author

ronso0 commented Dec 7, 2018

On the other hand experienced users will find a gap where the buttons originally where.

Yeah, I understand but IMO it's better for new users (and online reviewers:)

We will merge the library redesign branch soon

Regarding the performance and UX issues we found (and will find) I'm somehow doubtful the lib redesign will be available to regular users before 2.5 Even if it'll be in 2.4 we'd have about one more year with the current lib design.
Realizing this, I'd even vote for merging this to 2.2 as there are no risky code changes at all, just layout changes.

@daschuer
Copy link
Member

daschuer commented Dec 7, 2018

I am still eager to merge the redesign branch to 2.3. I think the best option is to just exclude the CPU consuming features.

This here is a nice idea, but the button position where not changed for many years and there is no need to change this for the remaining year.

@uklotzde
Copy link
Contributor

uklotzde commented Dec 8, 2018

I agree with @ronso0. The library redesign branch in its current state will not be ready for 2.3.

The UX is improved by these changes 👍 I would like to see this in 2.2.

@daschuer
Copy link
Member

daschuer commented Dec 9, 2018

The library redesign branch in its current state will not be ready for 2.3.

Yes, It need to be improved. Maybe we miss the 2.3 release date.

The UX is improved by these changes +1 I would like to see this in 2.2.

For 2.2? This is a master PR, for 2.3 currently. .

@ronso0
Copy link
Member Author

ronso0 commented Dec 9, 2018

After I noticed we'll still have a while until the lib-redesign, I'd target this at 2.2 if we reach a concensus to merge this asap.

@Be-ing
Copy link
Contributor

Be-ing commented Dec 26, 2018

LGTM. I'm in favor of merging this to master now.

@uklotzde uklotzde added this to the 2.3.0 milestone Dec 27, 2018
@Be-ing Be-ing merged commit 89a2891 into mixxxdj:master Dec 27, 2018
@ronso0
Copy link
Member Author

ronso0 commented Dec 27, 2018

Whoops, this was merged too early as I didn't mark it WIP.
qss is adjusted for Tango only, didn't touch the other skins as the discussion was still going..

I'll open a foolow-up asap.

@ronso0 ronso0 deleted the lib-feature-UX-improvements branch December 28, 2018 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants