Use QCollator for sort library. #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So many unknown goodies! LGTM 👍 Should we use the same technique in BaseSqlTableModel? Maybe we could even provide our own, reusable StringCollator class in util/string.h that uses a case-insensitive QCollator internally and provides overloaded methods for |
|
I've already prepared something, PR will follow in a moment... |
QCollator: Extensions and minor improvements
|
Thank you :-) |
|
If the CI build succeeds we should merge this nice improvement. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up library access, because we don't need to make a deep copy when calling toLower().