Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundTouch 2.1.1 #1961

Merged
merged 7 commits into from
Dec 28, 2018
Merged

SoundTouch 2.1.1 #1961

merged 7 commits into from
Dec 28, 2018

Conversation

uklotzde
Copy link
Contributor

Rebased and reopened after experiencing that Ubuntu 18.04 still includes libSoundTouch 1.9.2:
https://launchpad.net/ubuntu/+source/soundtouch

Predecessors:
#1907 (reopening the original PR was not possible)
#1960 (building without the bundled libSoundTouch fails)

@daschuer
Copy link
Member

This builds and woks here. Thank you.
Unfortunately AppVeyor complains: "Could not find Qt 5.11.2 at "". for the windows build.

@Be-ing
Copy link
Contributor

Be-ing commented Dec 26, 2018

Unfortunately AppVeyor complains: "Could not find Qt 5.11.2 at "". for the windows build.

I just fixed that earlier today: a47a6dd

@Be-ing
Copy link
Contributor

Be-ing commented Dec 26, 2018

There is a merge conflict with 84ca00e now.

@uklotzde
Copy link
Contributor Author

Rebased and fixed the merge conflict.

@uklotzde uklotzde added this to the 2.3.0 milestone Dec 27, 2018
@daschuer
Copy link
Member

LGTM, Thank you.

@daschuer daschuer merged commit 296f4b5 into mixxxdj:master Dec 28, 2018
@uklotzde uklotzde deleted the soundtouch-2.1.1 branch January 2, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants