-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak scratch parameters for Mixtrack Platinum #2028
Conversation
Did you intend to target this for the 2.2 branch? |
What exactly do you think have changed between 2.1 and 2.2? |
I didn't test this on 2.2 but it should probably go there too. I'm not sure what changed, but I don't think this has anything to do with the GUI spinners. This change makes the position indicator on the controller track better with the platter movements. Something changed with how the platter movements were being handled at some point such that moving the platter moved the spinner/track slightly more than it should have. This change tweaks the parameters to compensate for this. |
Have you adjusted your audio buffer size? |
It has nothing to do with audio buffer size as far as I can tell. I don't hear any issues there. The only thing affected appears to be how the jog wheel movements are interpreted. |
Considering the impact of this can't be tested without the actual hardware, I'll take your word that it's an improvement. It would be good to get confirmation from someone else with the hardware too. @JosepMaJAZ, could you test this? I changed the target branch to 2.2, but your branch needs to be rebased and force pushed for it to be able to be merged to the 2.2 branch. |
The behavior here appears to have changed between 2.1 and 2.2. This new value tracks better with the actual location of the spinner.
Rebased. |
@Be-ing What's the status of this? Ready to merge? |
Not sure. Depending on the version, I see different behavior. (or it could be different for tracks with different BPMs. I need to do some more testing) |
I just tested this with the 2.2.3 mac os release and it is definitely and improvement. So, IMO this is ready to merge. |
I'd be in favor merging this now. @JosepMaJAZ did not answered since April, so I guess we have to trust that @iamcodemaker tested this thoroughly. @Be-ing Do you agree? |
Yes sorry to let this fall through the cracks. |
The behavior here appears to have changed between 2.1 and 2.2. This new value tracks better with the actual location of the spinner.