Qm dsp upstream changes #2136
Merged
Qm dsp upstream changes #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess the file "lib/qm-dsp/mixx-changes.patch" should not be included? |
|
I have kept it to document our changes that are still differ from upstream. |
|
Then at least the typo in the file name should be fixed. |
|
OK file renamed and forced pushed. |
Closed
|
I'll test the changes and also disable the mutex for the key analyzer. |
|
LGTM. Thank you also for getting in contact with the QM team! Hopefully we can unify the key detection algorithms in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Queen Mary DSP repro is alive.
I have worked with @cannam to integrate the proposed patches.
Chris has also found a better solution for the noise issue #2112.
Thank you very much.