New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use snake_case for auto_hotcue_colors control object #2139

Merged

uklotzde merged 1 commit into mixxxdj:master from Holzhaus:auto-assign-hotcue-color-snake-case

Jun 4, 2019

Member

Holzhaus commented Jun 3, 2019

New controls should use snake_case by convention. Since this particular control has been part of a Mixxx release yet, we can safely rename it.


          Use snake_case for auto_hotcue_colors control object

e95b17a

Contributor

uklotzde commented Jun 4, 2019

LGTM.

I have updated the Wiki: https://www.mixxx.org/wiki/doku.php/mixxxcontrols#naming_conventions

uklotzde merged commit dae01c7 into mixxxdj:master

Member Author

Holzhaus commented Jun 4, 2019

@uklotzde Thanks. I had already added to the Control Developer Guide: https://www.mixxx.org/wiki/doku.php/developer_guide_control#control_naming
But it might make sense to have it on both wiki pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet