Add support for the battery widget on BSD systems (via upower) #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrrapha
commented
Jun 6, 2019
| return new BatteryWindows(parent); | ||
| #elif defined(Q_OS_MAC) | ||
| return new BatteryMac(parent); | ||
| #else | ||
| return new BatteryLinux(parent); |
There was a problem hiding this comment.
I made BatteryLinux the default here because otherwise we'd have to enumerate
Q_OS_LINUX, Q_OS_FREEBSD, Q_OS_OPENBSD and so on..
There was a problem hiding this comment.
I agree with this pragmatic approach. If this should ever fail in the future we could add a more fine-grained distinction for the "other" OSes.
|
Since there was no veto, let's merge it. LGTM, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upower is available on all major BSDs, so
batterlinux.cppcan be used for them.