Canonical URL/URI for track objects #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
requested changes
Jun 12, 2019
|
Thank you. LGTM |
daschuer
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate the URL/URI handling for tracks:
DragAndDropHelperSoundSourceProxyTrackRefhandle the creation of URLs fromQFileInfoand formatting of URIsThe URI is obtained by normalizing and formatting (percent-encoded) the
QUrl. It soon becomes the new track location in aoide.Next step for a follow-up PR: Split the
QFileInfo-related part fromTrackRefinto a separate classTrackFile. This will simplify ourTrackobject, but will cause many small changes in dependent code.