lp 16878282: Fix playlist import

[uklotzde]

• Accept text files that start with UTF-8 BOM
• Fix parsing of lines, i.e. comments start with '#' vs. file path may contain '#'

[daschuer]

Do we need to skip the utf8 bom?
Can skip in this case the other utf8 recognize call?

[uklotzde]

I have force-pushed the reformatted commits.

[daschuer]

There is a build issue:

[CXX] src\library\parser.cpp
parser.cpp
src\library\parser.cpp(71): error C2601: 'Parser::isUtf8': local function definitions are illegal
src\library\parser.cpp(40): note: this line contains a '{' which has not yet been matched
src\library\parser.cpp(149): error C2601: 'Parser::playlistEntrytoLocalFile': local function definitions are illegal
src\library\parser.cpp(40): note: this line contains a '{' which has not yet been matched
src\library\parser.cpp(40): fatal error C1075: the left brace '{' was unmatched at the end of the file
scons: *** [win64_build\library\parser.obj] Error 2
scons: building terminated because of errors.

[daschuer]

Mm, we can be sure that the # is encoded in all cases. Why not use the trimmed line above and then check for a preceding #?

[uklotzde]

Mm, we can be sure that the # is encoded in all cases. Why not use the trimmed line above and then check for a preceding #?

I don't understand what you want to tell me. That's what I did before -> startsWith(). After your comments I reverted back to the previous version where all lines containing a '#' are ignored.

[daschuer]

Your original solution was already Ok.
Sorry for the noise.

[uklotzde]

Ok, don't mind :)

[daschuer]

.. but building still fails.

[daschuer]

Thank you! LGTM