lp1840537: Enable (lib)modplug support on Linux by default #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Builds and works on Ubuntu Xenial. Do you wish to edit default.nix as well or merge it now? |
|
default.nix is only on master, I had to remove my changes temporarily for this PR ;) |
uklotzde
changed the title
|
Let's modify master after merging this one. |
|
Ok LGTM |
|
This made the build server fail. libmodplug needs to be installed there: |
|
My assumption was that everything needed for the .deb build is in build/debian/control? What else is missing? |
|
Maybe this: buildserver/pbuilderrc EXTRAPACKAGES |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/mixxx/+bug/1840537
What else needs to be done?
When merging to master we also need to update 2 different lines in default.nix!