Don't immediately jump when loopOut is pressed in quantized mode

[goddisignz]

Don't immediately jump to loop start when loopOut is pressed in quantized mode.
Same holds true for loopIn in reverse mode

Fixes https://bugs.launchpad.net/bugs/1837077

[daschuer]

Thank you for taking care. I think this fix is also relevant for 2.2.
Does this patch work in the 2.2 branch in the same way?

[daschuer]

Your comments can be improved by removing the c++ explaining parts and add some more background info. I will give an example inline.

[daschuer]

//m_bAdjustingLoopIn is true while the LoopIn button is pressed, (slotLoopIn)

[daschuer]

// If the loop in button was released in reverse mode, we need to jump to loop end to not fall out of the just set loop. This must not happen in qantized mode. Here we need to jump to a qantized position, which is handeled in ....

[goddisignz]

I think this fix should work on 2.2 as well (commit can be cherry-picked). But I can not build 2.2 currently.
After fixing a tab/space indentation in the SConscript I get the following error:

scons: *** [lin64_build/controllers/dlgprefcontrollers.o] Error 1
In file included from src/controllers/controller.h:15,
                 from src/controllers/midi/midicontroller.h:16,
                 from src/controllers/midi/midioutputhandler.cpp:12:
src/controllers/controllerengine.h: In member function ‘ScriptConnection& ScriptConnection::operator=(const ScriptConnection&)’:
src/controllers/controllerengine.h:31:7: warning: implicitly-declared ‘ConfigKey& ConfigKey::operator=(const ConfigKey&)’ is deprecated [-Wdeprecated-copy]
   31 | class ScriptConnection {
      |       ^~~~~~~~~~~~~~~~
In file included from src/preferences/usersettings.h:7,
                 from src/controllers/midi/midimessage.h:8,
                 from src/control/controlbehavior.h:7,
                 from src/control/control.h:9,
                 from src/control/controlproxy.h:8,
                 from src/controllers/midi/midioutputhandler.h:14,
                 from src/controllers/midi/midioutputhandler.cpp:11:
src/preferences/configobject.h:19:5: note: because ‘ConfigKey’ has user-provided ‘ConfigKey::ConfigKey(const ConfigKey&)’
   19 |     ConfigKey(const ConfigKey& key);
      |     ^~~~~~~~~
In file included from src/controllers/controller.h:15,
                 from src/controllers/midi/midicontroller.h:16,
                 from src/controllers/midi/midioutputhandler.cpp:12:
src/controllers/controllerengine.h: In constructor ‘ScriptConnectionInvokableWrapper::ScriptConnectionInvokableWrapper(ScriptConnection)’:
src/controllers/controllerengine.h:62:30: note: synthesized method ‘ScriptConnection& ScriptConnection::operator=(const ScriptConnection&)’ first required here
   62 |         m_scriptConnection = conn;
      |                              ^~~~
scons: building terminated because of errors.

Seems like a missing include directory because the files exist under lin64_build/src but I have no knowledge of scons to fix this.
Any advice?

[daschuer]

Sometimes scons tricks itself when switching branches. You can try to call scons --clean or just delete the lin64_build folder an the .sconsign.dblite or a fresh checkout.

In this case I think you there is no nee to bother with the scons issues.
Just cherry pick this commit into the 2.2 branch and create a new PR.
We can rely on Appveyor and Jenkins to see if it is builds and I can finally do a manual tests here.

[goddisignz]

OK, cleaning didn't help. Did not try a new checkout. I will create a new PR soon.