Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add battery_charging to latenight #2281

Merged
merged 1 commit into from
Nov 12, 2019
Merged

add battery_charging to latenight #2281

merged 1 commit into from
Nov 12, 2019

Conversation

nopeppermint
Copy link
Contributor

latenight_battery

@nopeppermint nopeppermint mentioned this pull request Sep 15, 2019
Merged
@daschuer
Copy link
Member

Thank you for taking care.
ic_battery_charging_0.svg should not be red, because it is not an alarming state.
All charging icons should be gray.
I would only use red colors for the low bat warning and remove the other colors like orange and yellow.
But that is a matter of taste, @ywwg is the taste master here.

@uklotzde uklotzde added the skins label Oct 20, 2019
@Be-ing
Copy link
Contributor

Be-ing commented Nov 12, 2019

ic_battery_charging_0.svg should not be red, because it is not an alarming state.

The other skins do this. I think it is good to keep the skins consistent for this. I would be okay with considering alternatives, but that should be done for all skins together. After this is merged, that can be done in a new PR if anyone feels so inclined to work on it.

LGTM, thank you @nopeppermint.

@Be-ing Be-ing merged commit b2da33d into mixxxdj:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nopeppermint @daschuer @Be-ing @uklotzde