[WIP] Allow skin styles for sidebar context menu #2297

ronso0 · 2019-09-23T20:40:27Z

Closed and split up:
Skins styles: #2337
C++ changes: #2338

IMO the right-click menus like in Tracks, sidebar and cover art are an annoying issue because the (often ugly) OS themes crashes into our designed Mixxx skins.
For Tracks and cover art a custom style can be applied by addressing QMenu and QMenu QCheckBox.

To make this work for the library sidebar context menu, too, I set the sidebar widget as parent for each library feature's context menus. For now, I did this for History and Computer feature.
Please check if this is the right approach, then I'll add this to the other features as well. (I need to clean up a bit anyway)

Also I removed a c++ stylesheet for the Tracks > Crates menu. This allows to override the OS styled checkboxes in the Crates menu, as well.

…r art)

daschuer

Thank you for investigate this.
The solution looks good and I have left some comments.

src/library/browse/browsefeature.cpp

daschuer · 2019-09-24T06:14:04Z

src/library/library.cpp

@@ -240,6 +241,8 @@ void Library::bindSidebarWidget(WLibrarySidebar* pSidebarWidget) {
    pSidebarWidget->slotSetFont(m_trackTableFont);
    connect(this, SIGNAL(setTrackTableFont(QFont)),
            pSidebarWidget, SLOT(slotSetFont(QFont)));
+    m_pSetlogFeature->bindSidebarWidget(pSidebarWidget);


Instead if name ach feature individual, you can use a loop over m_features

yes, indeed. The entire feature section can be optimized. There's a related ToDo from @rryan about that, but I didn't look into it, yet.

Be-ing · 2019-09-29T14:13:00Z

res/skins/Tango/style.qss

@@ -2083,11 +2083,56 @@ WTrackProperty#SamplerTitle_mini {
 ######  Misc  ##################################################
 ##############################################################*/

-QToolTip {
+QToolTip,
+QMenu {


Does this still work with #2238? Do you need to style CueMenu and ColorMenu in addition to QMenu?

It works, see the screenshot in the PR description which I composed from the hotcue label branch and this branch.
There are a few minor adjustments necessary though.
The LateNight screenshot only shows that it works in general, I'll take care of the other skins and the fine tuning when #2238 is merged

Be-ing · 2019-09-29T19:07:35Z

Some merge conflicts have developed.

Is this still a WIP?

ronso0 · 2019-09-29T19:09:33Z

My next step is to aply the solution for AutoDJ & History feature also to other features that have a sidebar context menu.
I'm not planning to overhaul the entire feature loading sequence here, like creating a separate method.

ronso0 · 2019-09-29T19:10:52Z

Is this still a WIP?

yes: I still need to implement the solution for AutoDJ, Playlists & Crates.

…e now

…r-qmenu-styling

ronso0 · 2019-10-07T12:50:34Z

I guess I can revert 6d9cb58 "default m_pMenu to nullptr", right?
If there's no sidebar widget there'll b no right-click and no menu so it doesn't matter at all.

ronso0 · 2019-10-07T15:03:11Z

The menu now looks nice for all library features, and also for the hotcue menu #2238
Please test.

nopeppermint · 2019-10-07T16:15:27Z

src/library/autodj/autodjfeature.cpp

-        QMenu contextMenu;
-        contextMenu.addMenu(&crateMenu);
-        contextMenu.exec(globalPos);
+        m_pMenu->addMenu(m_pCrateMenu);


change m_pMenu to m_pCrateMenu

and there are more build errors in library.c around line 132 "BrowseFeature"

for AutoDJ crateMenu leftover was the issue.
m_pMenu and m_pCrateMenu are correct

m_pBrowseFeature is also fixed now

nopeppermint · 2019-10-07T17:29:14Z

nice

styling for Shade could be better

ronso0 · 2019-10-07T17:42:15Z

* styling for Shade could be better

Haa! probably because I didn't do anything in Shade so far..neither in Deere
@daschuer If yo don't have any style preferences I'll base the tooltip and context menu style on each scheme, like in LateNight.
@Be-ing What about Deere? Any ideas?

ronso0 · 2019-10-23T14:43:02Z

The playlist context menus of Traktor and Rhythmbox playlist are not styled.

okay, so I guess I'll need to add the menu changes to library/baseexternallibraryfeature.cpp/h

I really don't have any idea how to accomplish this.
AFAICT BaseExternalLibraryFeature is loaded only once when each of the features is instantiated.
addFeature and bindSidebarWidget are separate functions in library.cpp.
How would I pass the sidebar widget pointer to each instance of BaseExternalLibraryFeature?

…r-qmenu-styling

Be-ing · 2019-10-26T21:34:32Z

The menus in Deere do now show any indicator for submenus.

ronso0 · 2019-10-26T23:37:00Z

The menus in Deere do now show any indicator for submenus.

yeah I know.. this is still WIP. I stumble over many issues, also unrelated to this PR, especially with scaled Library widgets.

ronso0 · 2019-10-26T23:45:07Z

Also this has grown beyond 'simply styling the menus'. I tried to match WEffectSelector and QToolTip and QMenu (in various places: hotcues, library header, tracks, sidebar, cover art, editlines), and by fixing all those incosistencies (besides the scaling issues with fonts and library controls) this PR is now kind of a GUI round-house kick.
Stay tuned! And please test the effect selector on Windows and MacOS.

@daschuer Please check the library in Shade. I dimmed the table header buttons and IMO all color schemes are much more pleasant now.

ronso0 · 2019-10-26T23:47:58Z

Did anyone ever try (or has any hints on how) to style the main menu bar?
This would the icing on the cake...

Btw: I still need help with passing sidebar widget to the baseexternallibraryfeature to style the iTunes and Banshee menu

ronso0 · 2019-10-27T14:06:05Z

Haa! Got it, I think.
Instead of this complex passing around of m_pSideBarWidget I can parent the menu on the fly to QApplication::focusWidget(). will test this, it would simplify the entire story and solve the issue with iTunes and Banshee..

ronso0 · 2019-10-28T19:19:44Z

I tested the suggested parent approach m_pMenu->setParent(anyWidget) with the Crates feature but this creates more issues than it could potentially avoid:

menu pops up at wrong place (cursorPos relative to widget 0,0 + global cursorPos)
menu is cropped by parent widget's geometry
menu won't close on selection or if I click outside the menu

That said, I'll have to try something else.

ronso0 · 2019-10-29T13:29:27Z

I think I've found a way to address the external features, as well.
Nevertheless, I'll split off the skin changes from this PR and leave only a small qss snippet for testing that can easily be removed, because the skin changes are huge and I'd like to include the new AutoDJ drop-down.

…menu later

ronso0 · 2019-10-29T18:17:50Z

Skins styles: #2337
C++ changes: #2338

ronso0 · 2019-10-29T18:19:02Z

Thanks for your help!

ronso0 added 4 commits September 23, 2019 22:28

parent right-lick menu to WSidebar in History & Computer feature

ae1915e

add skin styles for right-click menus (Tracks, sidebar, hotcues, cove…

ab68f46

…r art)

allow to override OS style of Crates submenu in Tracks table

e664f73

remove duplicate include QMenu

d662aad

daschuer requested changes Sep 24, 2019

View reviewed changes

ronso0 added 2 commits September 24, 2019 16:45

LateNight: add custom submenu arrow

5a58e9d

use nullptr, add/move m_pMenu->clear()

c8ab2cc

Be-ing reviewed Sep 29, 2019

View reviewed changes

ronso0 added 8 commits October 4, 2019 15:07

creat QMenu only once when the sidebarwidget is bound to library

ad518b1

add AutoDJ, Playlists and Crates feature

2dc6126

move feature includes to library.h

18c17a3

fix AutoDJ main context menu, test if Crates sub menu is also stylabl…

be96d29

…e now

default m_pMenu to nullptr

6d9cb58

test: add stylable menu to iTunes feature

63b37c9

reorder QMenu iniatilation according to compiler warnings

acdb70c

fix AutoDJ menu test

5455772

ronso0 closed this Oct 5, 2019

ronso0 reopened this Oct 5, 2019

Merge branch 'master' of https://github.com/mixxxdj/mixxx into sideba…

5d3b9f6

…r-qmenu-styling

ronso0 changed the title ~~[WIP] Allow skin styles for sidebar context menu~~ Allow skin styles for sidebar context menu Oct 6, 2019

increase menu padding a bit to separate icons and text

f07ab40

nopeppermint reviewed Oct 7, 2019

View reviewed changes

fix AutoDJ 'm_pCrateMenu' and 'm_pBrowseFeature'

fa2a88f

use nullptr instead of NULL in setlogfeature

cf68108

ronso0 added 8 commits October 26, 2019 18:42

style Shade menu & tooltip, adapt WEffecetSeletor & library button style

9cf9275

refine LateNight qmenu & effect selector style

0b390c6

add Deere qmenu, tooltip & effect selector style

99972ff

refine Shade qmenu & effect selector style

2191c8d

Merge branch 'master' of https://github.com/mixxxdj/mixxx into sideba…

e3d2b69

…r-qmenu-styling

Shade: fix some scaling and color scheme issues

95de89e

Shade: use pixel font for Broadcast button

bbe3511

tweak LateNight menu checkbox

913a227

fix scaling issues, tweak menus

9821062

ronso0 force-pushed the sidebar-qmenu-styling branch from 5bf4147 to 9821062 Compare October 27, 2019 14:02

ronso0 added 4 commits October 27, 2019 15:22

test: parent qmenu to QApplication::focusWidget()

25d6303

style Tango skin settings menu like context menus

76d6e44

Test: just bind sidebar widget, parent menu on right-click

e403dca

style LateNight skin settings like context menus

9ee5595

all lib features: bind sidebar widget, use as parent for right-click …

85366f5

…menu later

ronso0 changed the title ~~Allow skin styles for sidebar context menu~~ [WIP] Allow skin styles for sidebar context menu Oct 29, 2019

ronso0 closed this Oct 29, 2019

ronso0 deleted the sidebar-qmenu-styling branch October 29, 2019 20:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Allow skin styles for sidebar context menu #2297

[WIP] Allow skin styles for sidebar context menu #2297

ronso0 commented Sep 23, 2019 •

edited

Loading

daschuer left a comment

daschuer Sep 24, 2019

ronso0 Sep 24, 2019

Be-ing Sep 29, 2019

ronso0 Sep 29, 2019

Be-ing commented Sep 29, 2019

ronso0 commented Sep 29, 2019 •

edited

Loading

ronso0 commented Sep 29, 2019

ronso0 commented Oct 7, 2019

ronso0 commented Oct 7, 2019

nopeppermint Oct 7, 2019

nopeppermint Oct 7, 2019

ronso0 Oct 7, 2019

ronso0 Oct 7, 2019

nopeppermint commented Oct 7, 2019

ronso0 commented Oct 7, 2019

ronso0 commented Oct 23, 2019

Be-ing commented Oct 26, 2019

ronso0 commented Oct 26, 2019

ronso0 commented Oct 26, 2019 •

edited

Loading

ronso0 commented Oct 26, 2019 •

edited

Loading

ronso0 commented Oct 27, 2019

ronso0 commented Oct 28, 2019

ronso0 commented Oct 29, 2019

ronso0 commented Oct 29, 2019

ronso0 commented Oct 29, 2019

[WIP] Allow skin styles for sidebar context menu #2297

[WIP] Allow skin styles for sidebar context menu #2297

Conversation

ronso0 commented Sep 23, 2019 • edited Loading

daschuer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Be-ing commented Sep 29, 2019

ronso0 commented Sep 29, 2019 • edited Loading

ronso0 commented Sep 29, 2019

ronso0 commented Oct 7, 2019

ronso0 commented Oct 7, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nopeppermint commented Oct 7, 2019

ronso0 commented Oct 7, 2019

ronso0 commented Oct 23, 2019

Be-ing commented Oct 26, 2019

ronso0 commented Oct 26, 2019

ronso0 commented Oct 26, 2019 • edited Loading

ronso0 commented Oct 26, 2019 • edited Loading

ronso0 commented Oct 27, 2019

ronso0 commented Oct 28, 2019

ronso0 commented Oct 29, 2019

ronso0 commented Oct 29, 2019

ronso0 commented Oct 29, 2019

ronso0 commented Sep 23, 2019 •

edited

Loading

ronso0 commented Sep 29, 2019 •

edited

Loading

ronso0 commented Oct 26, 2019 •

edited

Loading

ronso0 commented Oct 26, 2019 •

edited

Loading