Fix export of extra metadata #2301
Conversation
|
Ups... Yes thank you. Just to verify I was looking a bit closer to this I have found:
https://de.m.wikipedia.org/wiki/ID3-Tag?wprov=sfla1 Are we sure that the GPR1 frame is exclusively used for that type of tracks? |
src/track/trackmetadatataglib.cpp
Outdated
| // Stick to traditional mapping if the new GRP1 | ||
| if ( | ||
| #if defined(__EXTRA_METADATA__) | ||
| trackMetadata.getTrackInfo().getWork().isNull() && |
There was a problem hiding this comment.
Is this condition true?
I wonder if iTunes use the work tag without GRP1 tag for mp4 files.
What do others, if we consider the iTunes way as a hotfix for TIT1 missuse?
There was a problem hiding this comment.
The corresponding (custom) MP4 atoms are well defined without any context-sensitive switching.
Maybe we should use the new mapping if work is available or movement is available or GRP1 is present in the file?
There was a problem hiding this comment.
Done. The new version of the export code now clearly distinguishes between either TIT1 or GRP1/TIT1/MVNM.
|
LGTM, Thank you. |
__EXTRA_METADATA__ifdefs were missing!causes writing the new tag GRP1 instead of TIT1 as intended.An additional fix that hides all extra properties in
AlbumInfoandTrackInfowill follow. This should then prevent any unintended usage in the future. It revealed the missing ifdefs that are fixed in this PR.