Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up: Use PainterScope everywhere #2302

Merged
merged 3 commits into from
Sep 28, 2019
Merged

Follow-up: Use PainterScope everywhere #2302

merged 3 commits into from
Sep 28, 2019

Conversation

uklotzde
Copy link
Contributor

  • Use PainterScope everywhere instead of manually invoking QPainter::save() and QPainter::restore()
  • Minor readability improvements in the recently changed table item delegates

@uklotzde uklotzde added this to the 2.3.0 milestone Sep 28, 2019
@daschuer
Copy link
Member

LGTM, Thank you very much for keeping the whole code consistent.

@daschuer daschuer merged commit 7839b7d into mixxxdj:master Sep 28, 2019
@uklotzde uklotzde deleted the painterscope branch September 28, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @daschuer