Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skins :: adjust styles of skin context menus, tooltip… 2nd attempt #2363

Merged
merged 47 commits into from
Feb 14, 2020
Merged

Skins :: adjust styles of skin context menus, tooltip… 2nd attempt #2363

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
b22cfc4
Revert "Revert "Skins :: adjust styles of skin context menus, tooltip…
ronso0 Nov 16, 2019
ddb2182
Deere: set bg color for (closed) WEffectSeletor
ronso0 Nov 18, 2019
c9e74ad
all skins: remove WEffectSelector hack from macOS stylesheets
ronso0 Nov 18, 2019
9916f6c
all skins: remove fixed font sized from QMenu & QToolTip
ronso0 Nov 21, 2019
6641709
restrict QScroolBar style to WLibrary and QTreeView pt1
ronso0 Nov 21, 2019
b40ea53
Merge remote-tracking branch 'mixxx/master' into skins-menu-styles
ronso0 Nov 24, 2019
0a84fc7
restrict styles for QLabel and QPushButton to WLibrary
ronso0 Nov 25, 2019
49fc104
LateNight: restrict QTableView, QTreeView & QScrollBar styles to library
ronso0 Nov 25, 2019
4579801
LateNight: restrict QHeaderView and QMenu styles to Mixxx widgets
ronso0 Nov 27, 2019
cadacad
LateNight: include WSpinny QMenu explicitely
ronso0 Nov 28, 2019
40a0ae2
Merge branch 'master' of https://github.com/mixxxdj/mixxx into skins-…
ronso0 Dec 4, 2019
7c72280
restrict QMenu, QHeaderView, QTableView, QTreeView styles to Mixxx
ronso0 Dec 5, 2019
b2de45d
Merge branch 'master' of https://github.com/mixxxdj/mixxx into skins-…
ronso0 Dec 5, 2019
b58f344
Deere: restrict QScrollBar style to library widgets
ronso0 Dec 5, 2019
b90a6ac
Tango: restrict styles to library widgets
ronso0 Dec 5, 2019
dbccac5
set Qt::WA_StyledBackground for WCueMenuPopup to allow custom qss bor…
ronso0 Dec 8, 2019
2b0c9b4
Merge branch 'master' of https://github.com/mixxxdj/mixxx into skins-…
ronso0 Dec 10, 2019
02d2da1
LateNight: fix schemes, clean up
ronso0 Dec 12, 2019
59b0fcb
Shade: : fix schemes, clean up
ronso0 Dec 13, 2019
d4bfafe
Shade: battery icons per scheme, sharpen broadcast button
ronso0 Dec 13, 2019
776560e
Deere: : fix schemes, clean up
ronso0 Dec 13, 2019
d3ba236
Tango: fix schemes, add focus border to lineedits, clean up
ronso0 Dec 17, 2019
312e276
Shade: put Library into Singleton to get custom font also for table e…
ronso0 Dec 22, 2019
00ca14f
remove obsolete font settings
ronso0 Dec 22, 2019
8ec115e
Shade: reduce big samplers' height
ronso0 Dec 22, 2019
93eb8d8
Shade: stretch mixer bg when 8 hotcues are enabled
ronso0 Dec 22, 2019
fc6b8a7
LateNight Flip: adjust lib feature controls, adjust colors
ronso0 Dec 22, 2019
85d280b
fix combobox & spinbox area on Windows
ronso0 Dec 23, 2019
16e69f6
LibraryBPMSpinbox: override system styles, add arrow icons
ronso0 Jan 4, 2020
b97fe31
LateNight Flip: adjust scrollbar styles
ronso0 Jan 5, 2020
5ef17e2
Shade: fix Hotcue buttons in samplers
ronso0 Jan 6, 2020
3ae2c8b
Shade: finally fix hotcue button colors
ronso0 Jan 6, 2020
23c5608
LateNight: attempt to prevent Mic/Aux labels from being cut off
ronso0 Jan 15, 2020
f2628a9
use library scrollbar style for WEffectSelector & AutoDJ combobox in …
ronso0 Jan 15, 2020
61bccb1
Merge branch 'master' of https://github.com/mixxxdj/mixxx into skins-…
ronso0 Jan 15, 2020
35de1c7
Shade: fix hotcue button template link
ronso0 Jan 15, 2020
717a610
small scheme fixes
ronso0 Jan 15, 2020
9c476b4
Deere: uniform color for hovered drop-down items
ronso0 Jan 17, 2020
0fb867d
Deere: relax toolbar spacing at minimal size
ronso0 Jan 17, 2020
9113eba
Deere: relax deck controls row at minimal size
ronso0 Jan 17, 2020
1574991
Deere: fix text highlight in decks' beatsize spinboxes
ronso0 Jan 17, 2020
74a1bba
set WCueMenuPopup QLabel text color in Tango & Deere
ronso0 Jan 22, 2020
738cc75
clean up Deere QHeaderView style
ronso0 Jan 22, 2020
2d10baf
Tango: set #CueLabelEdit text color explicitely
ronso0 Jan 23, 2020
bae31f3
Tango: opaque 'No Heaphone' hint
ronso0 Jan 23, 2020
8fb15a1
Merge branch 'master' into skins-menu-styles
ronso0 Feb 7, 2020
5e33be6
fix qss error, Deere/style.qss
ronso0 Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion res/skins/Deere/style-mac.qss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
}


/* hack to hide the checkmark, otherwise text gets cut off
/* Previously necessayr hack to hide the checkmark, otherwise text gets cut off
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just delete the code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For documentation. It took a while to notice and figure out the fix, so its valuble info IMO

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have the code deleted if it is no longer necessary. It is still in the Git history if that info is needed later.

on the right on Retina screens. This can only be done for macOS
because it cuts off text on the left on KDE
WEffectSelector QAbstractItemView {
Expand Down
2 changes: 1 addition & 1 deletion res/skins/LateNight/style-mac.qss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* hack to hide the checkmark, otherwise text gets cut off
/* Previously necessary hack to hide the checkmark, otherwise text gets cut off
on the right on Retina screens. This can only be done for macOS
because it cuts off text on the left on KDE
WEffectSelector QAbstractItemView {
Expand Down
8 changes: 4 additions & 4 deletions res/skins/Shade/style_mac.qss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/* hack around text getting cut off with scaled checkbox on Macs with Retina screens */
/* Previously necessary hack around text getting cut off with scaled checkbox on Macs with Retina screens
WEffectSelector QAbstractItemView {
margin: 0px 0px 0px -27px;
}
} */

/* just in case there is a partial checkmark shown on some untested screen, hide
the checkmark */
the checkmark
WEffectSelector::indicator {
border: 0;
}
} */
12 changes: 9 additions & 3 deletions res/skins/Tango/style-mac.qss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,13 @@
padding-right: 27px;
}


/* Previously necessary hack around text getting cut off with scaled checkbox on Macs with Retina screens
WEffectSelector QAbstractItemView {
padding: 0px 0px 0px -20px;
}
margin: 0px 0px 0px -27px;
} */

/* just in case there is a partial checkmark shown on some untested screen, hide
the checkmark
WEffectSelector::indicator {
border: 0;
} */