scripts/qsscheck: Also check default stylesheets #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ronso0 Any comments on this? |
|
nope. Can't evaluate the script, and I suppose @Holzhaus tested it sufficiently. |
|
@uklotzde We already found some issues using that script, e.g. #2387, #2374 and the qss syntax errors fixed by #2342. For the current master branch, there are no false positives. The script is certainly not perfect, but it can help keeping the qss scripts clean. If the script complains and we determine that it's a false positive, we can still ignore the warning and merge anyway, and also fix the script itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for qss stylesheets added in PR #2362.