Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping files for Hercules DJControl Inpulse 300 #2444

Closed
wants to merge 0 commits into from

Conversation

DJPhatso
Copy link
Contributor

Mapping files for Hercules DJControl Inpulse 300

Changes to v1.2

  • Code cleanup.

Changes to v1.1

  • Fix seek-to-start and cue-master behavior.
  • Tweak scratch, seek, and bend behavior (User settigns).
  • Controller knob/slider values are queried on startup, so MIXXX is synced.
  • Fixed vinyl button behavior the first time it's pressed.

v1.0 : Original forum release

@Holzhaus
Copy link
Member

Holzhaus commented Jan 16, 2020

Thanks for contributing!

Does this mapping use any new features that are not present in Mixxx 2.2? If not, please rebase this on the 2.2 branch.

EDIT: Instructions how to do that can be found here: #2425 (comment)

@DJPhatso
Copy link
Contributor Author

I made this mapping with Mixxx 2.2.2/2.2.3, so I guess I should be ok

@Holzhaus
Copy link
Member

I made this mapping with Mixxx 2.2.2/2.2.3, so I guess I should be ok

In that case please rebase on 2.2 and change the base branch of this PR to 2.2, too.

@DJPhatso DJPhatso changed the base branch from master to 2.2 January 16, 2020 16:01
@uklotzde
Copy link
Contributor

Please rebase, switching the target branch is not sufficient.

@Holzhaus
Copy link
Member

In case you don't know how to rebase:
https://mixxx.org/wiki/doku.php/using_git#targeting_another_base_branch

@Holzhaus
Copy link
Member

Holzhaus commented Jan 20, 2020

After rebasing on the current 2.2 branch, please move the mapping files into the res/controllers directory.
Also, you can auto-fix a lot of common code-style errors by running eslint:

$ eslint --fix res/controllers/Hercules-DJControl-Inpulse-300-script.js

@DJPhatso
Copy link
Contributor Author

Still trying to figure the rebase part.

If I may say, that's a lot a hoops to go through to submit 2 mapping file....

@DJPhatso DJPhatso closed this Jan 21, 2020
@Holzhaus
Copy link
Member

Hey @DJPhatso, did you close this PR because you didn't manage to rebase it? If you have problems with rebasing, feel free to post questions either here or on Zulip. We're glad to help if we can!

I it's too much work for you we can also just merge this to master instead (this will prevent it from being part of any 2.2.x release though).

@DJPhatso
Copy link
Contributor Author

New try here #2465.

Hopefully I've done everything right this time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants