engine/enginedeck: Don't stop playback if no passthru input is configured #2474
Conversation
|
Pinging @ronso0 for review ;-) |
|
woooh, was it that easy? nice |
|
oh sweet thanks |
|
The ci fails are unrelated |
Holzhaus
force-pushed
the
dont-stop-track-on-unconfigured-passthru
branch
from
64f3705
to
30674ab
Compare
Holzhaus
changed the title
|
This now uses |
This avoids stopping the playing deck if no input is configured for passthrough.
|
BaseTrackPlayerImpl::slotPassthroughEnabled mixxx/src/mixer/basetrackplayer.cpp Line 413 in 30674ab can be disposed now. |
|
You can connect noDeckPassthroughInputConfigured directly using pDeck->getEngineDeck(); Does noVinylControlInputConfigured suffer from the same issues? |
No, I don't think so. |
the prefs window should pop up if the user tries to enable vinyl control with no input selected |
Doesn't it? I thought it did when I tested it. |
? Are you saying it does suffer the same issue, or it does pop up the prefs window? It should pop up the prefs window. |
It does pop up the window, both with and without these changes. But it doesn't stop playback when activated while the input is unconfigured (which is the issue I thought we were talking about). |
|
ah, ok, sorry. right, correct, it doesn't stop playback |
|
LGTM, Thank you. |
This is related to PR #2466 and this discussion on Zulip:
https://mixxx.zulipchat.com/#narrow/stream/109122-general/topic/PASS.20button