…//github.com/JaviVilarroig/mixxx into bars_phrases_and_variable_BPM_in_beats_class

…variable_BPM_in_beats_class

Added support in BeatGrid and some minor fixes in BeatMap.

- Added Beats.setBar

The skin work is just a placeholder. I'm not so good in design.

- Extended BeatIterator for Bar and Phrase(partial) support.
- Extended BeatMap for Bar and Phrase(partial) management.
- Waveformrendererbeat extended to include the definition of the bar
beat color in the XML skin files.
- Tango Skin modified to include a button for marking bar beats.

…variable_BPM_in_beats_class

- Filename renamed to match class name
- Property names improved
- UItility constants renamed to fit variable coding rules

downbeat positions.

protobuff, improvement in some tooltips and name changes in some methods
and properties.

- BeatMap functionality moved to Beats class
- BeatGrid class removed
- BeatsFactory only creates Beats
- BeatGridTest removed
- Beats class moved to mixxx namespace
- Beats class uses frame number instead of sample number
  The original methods still exists. They transform sample into frames
  and call a method with the same name with "New" sufix. This is
  temporary until the rest of the code is adapted to use frames
- BeatsTest adapted to new Beats class

bars_phrases_and_variable_BPM_in_beats_class

# Conflicts:
#	.pre-commit-config.yaml
#	src/engine/controls/bpmcontrol.h
#	src/mixer/basetrackplayer.cpp
#	src/test/beatgridtest.cpp
#	src/test/beatmaptest.cpp
#	src/test/enginesynctest.cpp
#	src/track/beatgrid.cpp
#	src/track/beatgrid.h
#	src/track/beatmap.cpp
#	src/track/beatmap.h
#	src/track/track.cpp
#	src/track/track.h
#	src/widget/wtracktableview.cpp

….com:JaviVilarroig/mixxx into bars_phrases_and_variable_BPM_in_beats_class

- SIGSEV when using a BeatIterator created with a range outside the
Beats
- Last beat in was never reached

This is a requested improvement to increase readability.

bars_phrases_and_variable_BPM_in_beats_class

# Conflicts:
#	src/analyzer/analyzerbeats.cpp
#	src/engine/controls/bpmcontrol.cpp
#	src/engine/controls/bpmcontrol.h
#	src/engine/controls/clockcontrol.cpp
#	src/engine/controls/clockcontrol.h
#	src/engine/controls/loopingcontrol.cpp
#	src/engine/controls/quantizecontrol.cpp
#	src/engine/controls/quantizecontrol.h
#	src/library/banshee/bansheeplaylistmodel.cpp
#	src/library/dao/trackdao.cpp
#	src/library/rekordbox/rekordboxfeature.cpp
#	src/mixer/basetrackplayer.cpp
#	src/test/beatgridtest.cpp
#	src/test/beatmaptest.cpp
#	src/test/beatstranslatetest.cpp
#	src/test/bpmcontrol_test.cpp
#	src/test/enginesynctest.cpp
#	src/track/beatfactory.cpp
#	src/track/beatfactory.h
#	src/track/beatgrid.cpp
#	src/track/beatgrid.h
#	src/track/beatmap.cpp
#	src/track/beatmap.h
#	src/track/beats.cpp
#	src/track/beats.h
#	src/track/track.cpp
#	src/widget/wtrackmenu.cpp

Minor fixes in Beats.
Improvements in BeatsTest
Improvements on BeatTranslateTest

…ence is true (#1)

* fix scons build

* beatmap behave like beatgrid when constant tempo preference is true

Co-authored-by: Cristiano <cristiano.lacerda@usp.br>
Co-authored-by: JaviVilarroig <43292281+JaviVilarroig@users.noreply.github.com>

…o preference is true (#1)"

This reverts commit 920d1c6.

It introduces an issue in mixxx engine. We can continue working on this
functionality in parallel.

- Changes in Beats to use Bpm
- Changes in tests to use Bpm
- Added some operators in Bpm