Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Controller Script Error Reporting #2588

Merged
merged 22 commits into from
Apr 18, 2020
Merged

Improve Controller Script Error Reporting #2588

merged 22 commits into from
Apr 18, 2020

Commits on Mar 22, 2020

  1. controllers/controllerengine: Improve error messages for mappings

    @Holzhaus
    Holzhaus committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    a07164d View commit details
    Browse the repository at this point in the history

  2. controllers/controllerengine: Enable errors popups in all cases

    @Holzhaus
    Holzhaus committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    fe4aae2 View commit details
    Browse the repository at this point in the history

  3. controllers/controllerengine: Add missing nullptr checks

    @Holzhaus
    Holzhaus committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    0b55805 View commit details
    Browse the repository at this point in the history

  4. controllers/controllerengine: Move uninitialize engine code into method

    @Holzhaus
    Holzhaus committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    3bf5b0b View commit details
    Browse the repository at this point in the history

  5. controllers/controllerengine: Uninitalize if script load failed

    @Holzhaus
    Holzhaus committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    2bc6e89 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2020

  1. Merge branch 'master' of github.com:mixxxdj/mixxx into script-error-r… 

    …eporting
    @Holzhaus
    Holzhaus committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    c64a0e1 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2020

  1. controllers/controllerengine: Remove duplicated code and fix popup logic

    @Holzhaus
    Holzhaus committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    f82fcc8 View commit details
    Browse the repository at this point in the history

  2. controllers/controllerengine: Always show the backtrace on script errors 

    Previously the backtrace was only added to the error details if
the `--controllerDebug` flag was passed to Mixxx. Since the error
details are only displayed if the user explicitly uncollapsed the
"Details" expander and non-technical users won't be able to make use of
the engine's error message and line number anyway, we can just show it
unconditionally. This might even result in more helpful bug reports.
    @Holzhaus
    Holzhaus committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    1d6d81e View commit details
    Browse the repository at this point in the history

  3. controllers/controllerengine: Fix error message text

    @Holzhaus
    Holzhaus committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    5ad0f27 View commit details
    Browse the repository at this point in the history

  4. controllers/controllerengine: Further improve error dialog details

    @Holzhaus
    Holzhaus committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    712ced4 View commit details
    Browse the repository at this point in the history

  5. controllers/controllerengine: Use monospace font for script error det… 

    …ails
    @Holzhaus
    Holzhaus committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    0e29507 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2020

  1. controllers/controllerengine: Fix wrong debug assertion

    @Holzhaus
    Holzhaus committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    a4fde4f View commit details
    Browse the repository at this point in the history

  2. controllers/controllerengine: Remove unusued getErrors method

    @Holzhaus
    Holzhaus committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    456f8ab View commit details
    Browse the repository at this point in the history

  3. controllers/controllerengine: Clear script errors upon reinitialization

    @Holzhaus
    Holzhaus committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    e1abe15 View commit details
    Browse the repository at this point in the history

  4. controllers/controllerengine: Make errors during script init fatal

    @Holzhaus
    Holzhaus committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    cee2458 View commit details
    Browse the repository at this point in the history

  5. controllers/controllerengine: Removed unused initialized signal

    @Holzhaus
    Holzhaus committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    c8d96a3 View commit details
    Browse the repository at this point in the history

  6. controllers/controllerengine: Do not translate script error messages

    @Holzhaus
    Holzhaus committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    961d9a0 View commit details
    Browse the repository at this point in the history

  7. controllers/controllerengine: Improve file open error message

    @Holzhaus
    Holzhaus committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    7c0d692 View commit details
    Browse the repository at this point in the history

  8. controllers/controllerengine: Stop engine if controller init fails

    @Holzhaus
    Holzhaus committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    0d1cf7f View commit details
    Browse the repository at this point in the history

  9. controllers/controllerengine: Improve syntax check error message

    @Holzhaus
    Holzhaus committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    1a15898 View commit details
    Browse the repository at this point in the history

  10. controllers/controllerengine: Use key without backtrace for "ignore e… 

    …rror"
    @Holzhaus
    Holzhaus committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    c9a5ca5 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2020

  1. controllers/controllerengine: Use debug assert in callFunctionOnObjects

    @Holzhaus
    Holzhaus committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    1d3f91c View commit details
    Browse the repository at this point in the history