Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback to pause brake effect #2591

Closed
wants to merge 2 commits into from
Closed

Playback to pause brake effect #2591

wants to merge 2 commits into from

Conversation

goddisignz
Copy link
Contributor

Introduces a brake effect when playback is paused.

  • When it is activated it linearly decreases the playback speed until it becomes zero.
  • The effect time until full stop can be configured in the deck preferences
  • An effect time of zero disables the effect.
  • It only reacts on button presses (UI-press, keyboard, or controller). Direct changes to the play state behave like before.
  • During brake, pressing the button again immediately resumes to playback, quantized if enabled. This does not work for the UI-press because of the control objects state modification mechanism. Here, another click results in an immediate stop.
  • For UI-press, only Deere is supported up to now. Other skins will have to introduce a three-state button accordingly.

@goddisignz
Copy link
Contributor Author

Hm, seems like I am not completely done here.

@goddisignz goddisignz closed this Mar 23, 2020
@georgitsenov
Copy link

Hay @goddisignz I am trying to find a way to enable vinyl break, like it can be configured in Serato in order to perform this:
https://youtu.be/3dl2Lpnqy0w

I checked on various repositories, mixxx forums and launchpad and this pull request is the closest thing, that I found.
Do you have any info on how this can be enabled, or what is the progress % on your implementation?

Best Regards!

@ywwg
Copy link
Member

ywwg commented Jun 28, 2021

you can leave this PR open and convert it to Draft mode, then when it's ready you can request reviews

@ronso0
Copy link
Member

ronso0 commented Jun 28, 2021

unfortunately this can't be reopened because it targets now nonexistant master.
@goddisignz In case you intend to continue working on this: leaving a PR open also allows repo members to pick up the PR and push chnages as well as merging the target branch every now and then in order to avoid too many conflicts stack up over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants