Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

effect chain preset saving/loading, custom effect defaults, and parameter hiding/rearrangement #2618

Closed
wants to merge 552 commits into from
Closed

effect chain preset saving/loading, custom effect defaults, and parameter hiding/rearrangement #2618

wants to merge 552 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Dec 1, 2020

  1. LV2Backend: prevent copying container in for loop

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    42ea49e View commit details
    Browse the repository at this point in the history

  2. effects: fix clazy warnings

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    d834b37 View commit details
    Browse the repository at this point in the history

  3. add comment about EffectBackendType sort order

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    4882396 View commit details
    Browse the repository at this point in the history

  4. EffectManifest: use QLatin1String

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    3d045f4 View commit details
    Browse the repository at this point in the history

  5. EffectManifest::backendName: add comment noting it is for internal us… 

    …e only
    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    0cd1fb8 View commit details
    Browse the repository at this point in the history

  6. EffectsBackend::backendTypeToString use switch-case statement

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    f214a3c View commit details
    Browse the repository at this point in the history

  7. effects: fix more clazy warnings

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    c40ff25 View commit details
    Browse the repository at this point in the history

  8. EffectSlot: avoid copies in loops

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    518baf9 View commit details
    Browse the repository at this point in the history

  9. effects: clang-format everything in src/effects

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    aa67f47 View commit details
    Browse the repository at this point in the history

  10. effects: clang-format everything in src/engine/effects

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    260ed55 View commit details
    Browse the repository at this point in the history

  11. ControlEffectKnob: clang-format

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    ca658f8 View commit details
    Browse the repository at this point in the history

  12. ControlPickerMenu: clang-format

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    b6078a0 View commit details
    Browse the repository at this point in the history

  13. effects: clang-format widgets

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    c4ede6c View commit details
    Browse the repository at this point in the history

  14. effects: clang-format tests

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    8121a34 View commit details
    Browse the repository at this point in the history

  15. DlgPrefEffects: clang-format

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    a08a1cc View commit details
    Browse the repository at this point in the history

  16. DlgPrefEQ: clang-format

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    a55a967 View commit details
    Browse the repository at this point in the history

  17. make pre-commit shut up

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    de38b7d View commit details
    Browse the repository at this point in the history

  18. fix Qt 5.9 build

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    118ec6c View commit details
    Browse the repository at this point in the history

  19. BuiltInBackend: clean up effect registration 

    Now with lambdas and unique_ptrs. Yay modern C++.
    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    685425b View commit details
    Browse the repository at this point in the history

  20. EffectsBackendManager: update comment

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    bea6016 View commit details
    Browse the repository at this point in the history

  21. LV2EffectProcessor: remove unnecessary #include

    @Be-ing
    Be-ing committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    862b7b6 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2020

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    24047c1 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    9cf9d31 View commit details
    Browse the repository at this point in the history

  2. make pre-commit happy

    @Be-ing
    Be-ing committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    0b9dfa3 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    2895b67 View commit details
    Browse the repository at this point in the history

  2. DlgPreferences: remove unused parameter from merge conflict

    @Be-ing
    Be-ing committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    95b1ab4 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    c7612e9 View commit details
    Browse the repository at this point in the history

  2. EffectsBackendManager: change debug assertion to if statement

    @Be-ing
    Be-ing committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    a4cae3f View commit details
    Browse the repository at this point in the history

  3. EffectChainPresetManager: fix debug assertion without config

    @Be-ing
    Be-ing committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    e5e0ecc View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    20f22e4 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    a16aa4c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    c12036f View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    e8bfd6e View commit details
    Browse the repository at this point in the history

  2. DlgPreferences: remove unused parameter

    @Be-ing
    Be-ing committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    6c0676d View commit details
    Browse the repository at this point in the history

  3. update legacy variable name to current convention

    @Be-ing
    Be-ing committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    917ed3c View commit details
    Browse the repository at this point in the history

  4. remove unneeded MOC includes for non-QObject classes

    @Be-ing
    Be-ing committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    3a53a78 View commit details
    Browse the repository at this point in the history

  5. remove unused #include

    @Be-ing
    Be-ing committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    cba4582 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    9ea168b View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2020

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    277f57b View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    50a950a View commit details
    Browse the repository at this point in the history

  2. EffectChainPresetManager: forbid presets with empty names

    @Be-ing
    Be-ing committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    6bbfa82 View commit details
    Browse the repository at this point in the history

  3. EffectChainPresetManager: validate user-entered name

    @Be-ing
    Be-ing committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    c95e8bb View commit details
    Browse the repository at this point in the history

  4. DlgPrefEffects: rearrange text, add hint about controllers

    @Be-ing
    Be-ing committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    9870c1e View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2020

  1. EffectChainPresetManager: prevent empty rename when importing

    @Be-ing
    Be-ing committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    8d2196d View commit details
    Browse the repository at this point in the history

  2. WEffectChainPresetButton: fix off by one error in label

    @Be-ing
    Be-ing committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    381f800 View commit details
    Browse the repository at this point in the history

  3. EffectChainPresetManager: validate name of new chain presets

    @Be-ing
    Be-ing committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    60ea96c View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    0080faf View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    b84698d View commit details
    Browse the repository at this point in the history

  2. fix code style issues after merge

    @Be-ing
    Be-ing committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    f72ae7d View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Jan 24, 2021
    Configuration menu
    Copy the full SHA
    017619c View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    fa11158 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. make pre-commit happy

    @Be-ing
    Be-ing committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    628f75e View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Feb 6, 2021
    Configuration menu
    Copy the full SHA
    45cedc0 View commit details
    Browse the repository at this point in the history

  2. EffectChainPresetManager: trim whitespace from preset names

    @Be-ing
    Be-ing committed Feb 6, 2021
    Configuration menu
    Copy the full SHA
    2f57c7c View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    9ca79b8 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    b52f427 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    579236d View commit details
    Browse the repository at this point in the history

  3. LV2EffectProcessor: fix lilv header include

    @Be-ing
    Be-ing committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    6229788 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    ef8b0f4 View commit details
    Browse the repository at this point in the history

  2. DlgPreferences: clang-format fix

    @Be-ing
    Be-ing committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    0ad3286 View commit details
    Browse the repository at this point in the history

  3. WEffectPushButton: fix crash with invalid skins

    @Be-ing
    Be-ing committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    c58da3d View commit details
    Browse the repository at this point in the history

  4. EffectChainPresetManager: trim whitespace from imported presets

    @Be-ing
    Be-ing committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    4396b8c View commit details
    Browse the repository at this point in the history

  5. WEffectChainPresetSelector: do not change preset on mouse scroll

    @Be-ing
    Be-ing committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    efeab5b View commit details
    Browse the repository at this point in the history

  6. WEffectChainPresetSelector: set tooltips

    @Be-ing
    Be-ing committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    386eba9 View commit details
    Browse the repository at this point in the history

  7. WEffectChainPresetButton: do not accept focus

    @Be-ing
    Be-ing committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    6c375c6 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. WEffectChainPresetButton: remove superfluous connection to show menu

    @Be-ing
    Be-ing committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    2bcfd54 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    021ab5f View commit details
    Browse the repository at this point in the history

  3. Tango: fix fx slot v-layout with Super knobs

    @ronso0 @Be-ing
    ronso0 authored and Be-ing committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    879dcca View commit details
    Browse the repository at this point in the history

  4. Tango: push deck mixer to top with jump/loop controls shown

    @ronso0 @Be-ing
    ronso0 authored and Be-ing committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    bc21e16 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Merge branch 'main' into effects_refactoring

    @ronso0
    ronso0 authored Mar 1, 2021
    Configuration menu
    Copy the full SHA
    ccc0171 View commit details
    Browse the repository at this point in the history

  2. WEffectChainPresetButton: note stylesheet support in TODO 

    Co-authored-by: ronso0 <ronso0@mixxx.org>
    @Be-ing @ronso0
    Be-ing and ronso0 authored Mar 1, 2021
    Configuration menu
    Copy the full SHA
    19a6ef7 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. EffectManifestParameter: remove commented debug message 

    Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
    @Be-ing @Swiftb0y
    Be-ing and Swiftb0y authored Mar 4, 2021
    Configuration menu
    Copy the full SHA
    dc1bdca View commit details
    Browse the repository at this point in the history

  2. BuiltInBackend: remove commented debug message 

    Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
    @Be-ing @Swiftb0y
    Be-ing and Swiftb0y authored Mar 4, 2021
    Configuration menu
    Copy the full SHA
    9dd8b8c View commit details
    Browse the repository at this point in the history

  3. EffectKnobParameterSlot: replace legacy NULL with nullptr 

    Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
    @Be-ing @Swiftb0y
    Be-ing and Swiftb0y authored Mar 4, 2021
    Configuration menu
    Copy the full SHA
    1f95765 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. EffectState: improve documentation

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    7011afb View commit details
    Browse the repository at this point in the history

  2. EffectProcessor: clarify which methods are called from which thread

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    46cb0b9 View commit details
    Browse the repository at this point in the history

  3. EffectsManager: add a note about initializing submanager classes

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    674655d View commit details
    Browse the repository at this point in the history

  4. StandardEffectChain: add note about confusing EffectRack COs

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    e914b81 View commit details
    Browse the repository at this point in the history

  5. EffectSlot: clang-tidy cleanup

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    eeb1efb View commit details
    Browse the repository at this point in the history

  6. EffectChain: clang-tidy cleanup

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    f8ac928 View commit details
    Browse the repository at this point in the history

  7. EngineEffect: improve documentation

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    550eca1 View commit details
    Browse the repository at this point in the history

  8. EngineEffectsManager: add/update documentation

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    c7ac571 View commit details
    Browse the repository at this point in the history

  9. GroupFeatureState: add documentation

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    d7f10d1 View commit details
    Browse the repository at this point in the history

  10. SpecialEffectChains: add documentation

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    fdfb57f View commit details
    Browse the repository at this point in the history

  11. EngineEffectChain: replace NULL with nullptr

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    cf29915 View commit details
    Browse the repository at this point in the history

  12. EngineEffectChain: remove unused method

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    4c281f1 View commit details
    Browse the repository at this point in the history

  13. EngineEffectChain: add documentation

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    7161502 View commit details
    Browse the repository at this point in the history

  14. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    5404a5f View commit details
    Browse the repository at this point in the history

  15. SpecialEffectChains: fix grammatical error

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    48d15b4 View commit details
    Browse the repository at this point in the history

  16. PerGroupEffectChain: clarify documentation

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    7319d0e View commit details
    Browse the repository at this point in the history

  17. effects: fix inheritance issues

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    56fe847 View commit details
    Browse the repository at this point in the history

  18. EffectsBackend/EffectManifest: consolidate redundant string literals

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    10cc327 View commit details
    Browse the repository at this point in the history

  19. EffectsBackend: fix typo in documentation

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    a3efdc9 View commit details
    Browse the repository at this point in the history

  20. DlgPrefEq: do not repeat string literal

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    afe8dbd View commit details
    Browse the repository at this point in the history

  21. EffectManifestParameter: remove unused SemanticHint enum

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    1be263b View commit details
    Browse the repository at this point in the history

  22. EngineEffectsManager: clarify why allocating in audio thread is okay

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    3af6071 View commit details
    Browse the repository at this point in the history

  23. EffectState: elaborate in documentation

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    c5d522d View commit details
    Browse the repository at this point in the history

  24. WEffectChainPresetButton: remove redundant connections

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    89b8247 View commit details
    Browse the repository at this point in the history

  25. EffectProcessorImpl: update documentation

    @Be-ing
    Be-ing committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    89296b7 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2021

  1. ParametricEqEffect: update URL for Discourse forum

    @Be-ing
    Be-ing committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    d92120b View commit details
    Browse the repository at this point in the history

  2. ParametricEQEffect: add notes about allocation not in audio thread

    @Be-ing
    Be-ing committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    37a3ef1 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    6056189 View commit details
    Browse the repository at this point in the history

  4. EffectState/EffectProcessor: improve documentation

    @Be-ing
    Be-ing committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    e744a53 View commit details
    Browse the repository at this point in the history

  5. EffectChainPreset: update documentation

    @Be-ing
    Be-ing committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    c9c0718 View commit details
    Browse the repository at this point in the history

  6. EffectsMessenger: add link explaining design choice

    @Be-ing
    Be-ing committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    8f73c7d View commit details
    Browse the repository at this point in the history

  7. EngineEffectsManager: improve documentation

    @Be-ing
    Be-ing committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    206db13 View commit details
    Browse the repository at this point in the history

  8. EngineEffect: clarify documentation

    @Be-ing
    Be-ing committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    58d58c3 View commit details
    Browse the repository at this point in the history

  9. EngineEffectsManager: add documentation for methods

    @Be-ing
    Be-ing committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    eeac82b View commit details
    Browse the repository at this point in the history

  10. EngineEffectsManager: add signal flow diagram

    @Be-ing
    Be-ing committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    fb905f8 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    da65f77 View commit details
    Browse the repository at this point in the history

  2. DlgPrefEQ: remove static keyword from functions in anonymous namespace

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    645a83e View commit details
    Browse the repository at this point in the history

  3. DlgPrefEQ: remove unneeded else branch

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    60f7bdd View commit details
    Browse the repository at this point in the history

  4. EffectsManager: remove unused string constants

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    3f1beb1 View commit details
    Browse the repository at this point in the history

  5. EffectsMessenger: rename startShutdownProcess to initiateShutdown

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    3d5931e View commit details
    Browse the repository at this point in the history

  6. EchoEffect: restore accidentally deleted setMetaKnobDefault call

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    72d05af View commit details
    Browse the repository at this point in the history

  7. ParametricEQEffect: use SampleRate class instead of unsigned int

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    7e17294 View commit details
    Browse the repository at this point in the history

  8. EffectManifest: rename alphabetize to sortLexigraphically

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    8c6636d View commit details
    Browse the repository at this point in the history

  9. EngineEffect: remove unused m_pEffectsManager member

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    fd57f63 View commit details
    Browse the repository at this point in the history

  10. use kNoEffectString constant more

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    ae9693d View commit details
    Browse the repository at this point in the history

  11. EffectChainPresetManager: remove unused member

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    a62cbc8 View commit details
    Browse the repository at this point in the history

  12. EffectsMessenger: document that it runs in the main thread

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    236af41 View commit details
    Browse the repository at this point in the history

  13. DlgPrefEffects: use parented_ptr

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    3c7403e View commit details
    Browse the repository at this point in the history

  14. EffectChainPresetManager: separate error text with a newline

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    cb58adf View commit details
    Browse the repository at this point in the history

  15. EffectChain: add debug assertions regarding EngineEffectChain

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    006216a View commit details
    Browse the repository at this point in the history

  16. Tango: add basic styles for menu of WEffectChainPresetButton

    @ronso0 @Be-ing
    ronso0 authored and Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    81df0bf View commit details
    Browse the repository at this point in the history

  17. EffectParameterSlot: remove unused m_pEffectSlot

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    7f94758 View commit details
    Browse the repository at this point in the history

  18. EffectChain: static_cast enum class directly to double

    @Be-ing
    Be-ing committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    0ea0d74 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. EffectChain: consolidate load_preset and loaded_preset into one RW CO

    @Be-ing
    Be-ing committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    7cbaaf6 View commit details
    Browse the repository at this point in the history

  2. EffectChain: fix loaded_preset off-by-one error

    @Be-ing
    Be-ing committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    661ac8f View commit details
    Browse the repository at this point in the history

  3. EffectChain: update loaded_preset when chain list is updated

    @Be-ing
    Be-ing committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    da2e71b View commit details
    Browse the repository at this point in the history

  4. EffectChain: rename nameChanged signal to presetNameChanged

    @Be-ing
    Be-ing committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    4a12d74 View commit details
    Browse the repository at this point in the history

  5. EffectSlot: rename load_effect to loaded_effect and make it read/write

    @Be-ing
    Be-ing committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    1c7c9b7 View commit details
    Browse the repository at this point in the history

  6. EffectChain: remove setPresetName method

    @Be-ing
    Be-ing committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    ad70288 View commit details
    Browse the repository at this point in the history

  7. VisibleEffectsList: use debug assertions

    @Be-ing
    Be-ing committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    fef8a44 View commit details
    Browse the repository at this point in the history

  8. Revert "EchoEffect: restore accidentally deleted setMetaKnobDefault c… 

    …all"

This reverts commit 72d05af.

This was changed intentionally in
03f5a3b
    @Be-ing
    Be-ing committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    4263380 View commit details
    Browse the repository at this point in the history

  9. EffectManifest: optimize sortLexigraphically function

    @Be-ing
    Be-ing committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    7d72822 View commit details
    Browse the repository at this point in the history

  10. EffectChain: fix setting of mix and mix_mode defaults

    @Be-ing
    Be-ing committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    341f6e9 View commit details
    Browse the repository at this point in the history

  11. split EffectChain subclasses into separate files

    @Be-ing
    Be-ing committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    7b0a0d5 View commit details
    Browse the repository at this point in the history

  12. rearrange #includes

    @Be-ing
    Be-ing committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    e53faa3 View commit details
    Browse the repository at this point in the history

  13. EffectChainPresetManager: add comment explaining sorting order

    @Be-ing
    Be-ing committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    ae4aba7 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2021

  1. DlgPrefEQ: disable EQ acting on waveform when loading non-EQ effect

    @Be-ing
    Be-ing committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    aa9a449 View commit details
    Browse the repository at this point in the history

  2. EffectsManager: rename isAdoptMetaknobValueEnabled 

    to isAdoptMetaknobSettingEnabled
    @Be-ing
    Be-ing committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    16e113c View commit details
    Browse the repository at this point in the history

  3. DlgPrefEQ: fix loading of settings

    @Be-ing
    Be-ing committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    ce2b4a6 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    ea70102 View commit details
    Browse the repository at this point in the history

  5. EffectsBackendManager: fix handling of upgrade from Mixxx 2.3

    @Be-ing
    Be-ing committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    077372d View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2021

  1. EffectChainPresetManager: fix renaming presets 

    Before, the renamed file got saved but it got saved without changing the
name in the XML.
    @Be-ing
    Be-ing committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    0a7987c View commit details
    Browse the repository at this point in the history

  2. log warnings when failing to read effect chain preset XML file

    @Be-ing
    Be-ing committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    e303837 View commit details
    Browse the repository at this point in the history

  3. EffectChainPresetManager: fix deletion of presets with sanitized names

    @Be-ing
    Be-ing committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    d4a1bca View commit details
    Browse the repository at this point in the history

  4. Tango: fixup effect chain menu

    @ronso0 @Be-ing
    ronso0 authored and Be-ing committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    d0af5f4 View commit details
    Browse the repository at this point in the history

  5. Tango: style QuickEffect selector

    @ronso0 @Be-ing
    ronso0 authored and Be-ing committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    9602609 View commit details
    Browse the repository at this point in the history

  6. Tango: style WEffectChainPresetButton

    @ronso0 @Be-ing
    ronso0 authored and Be-ing committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    bcd3383 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. DlgPrefEffects: reimport default presets with Defaults button

    @Be-ing
    Be-ing committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    e7b8061 View commit details
    Browse the repository at this point in the history

  2. EffectChainPresetManager: use "Export" in title of export dialog

    @Be-ing
    Be-ing committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    328e3a3 View commit details
    Browse the repository at this point in the history

  3. WEffectChainPresetButton: "Save preset" -> "Save new preset"

    @Be-ing
    Be-ing committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    642ebd1 View commit details
    Browse the repository at this point in the history

  4. use QChar and QStringLiteral in effects item models

    @Be-ing
    Be-ing committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    c525026 View commit details
    Browse the repository at this point in the history

  5. EffectsBackend: use constexpr char[] for translated strings

    @Be-ing
    Be-ing committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    7124c1a View commit details
    Browse the repository at this point in the history

  6. turn EffectChainMixMode into a class with a Type enum

    @Be-ing
    Be-ing committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    d601fcb View commit details
    Browse the repository at this point in the history

  7. EffectChain: fix slotControlLoadedChainPresetRequest for QuickEffectC… 

    …hains

Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
    @Be-ing @Swiftb0y
    Be-ing and Swiftb0y authored Mar 15, 2021
    Configuration menu
    Copy the full SHA
    2151a8f View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    f70d342 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. EffectChainPresetManager: handle old effects.xml with presets existing

    @Be-ing
    Be-ing committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    5060718 View commit details
    Browse the repository at this point in the history

  2. EffectChainPresetManager: improve error handling in importDefaultPresets

    @Be-ing
    Be-ing committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    13a438e View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    a0dc621 View commit details
    Browse the repository at this point in the history

  4. EffectChainPresetManager: fix emission of lists updated signals

    @Be-ing
    Be-ing committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    dd7ba9b View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. WEffectChainPresetButton: hardcode 3 effect slots for now

    @Be-ing
    Be-ing committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    d71cb69 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    e90b493 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    0c7d453 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. LateNight: fix broken style

    @Be-ing
    Be-ing committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    75c7246 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Merge remote-tracking branch 'mixxx/main' into effrefact3

    @ronso0
    ronso0 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    c637cae View commit details
    Browse the repository at this point in the history

  2. fxrefact-resolve-conflicts

    @ronso0
    ronso0 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    1492915 View commit details
    Browse the repository at this point in the history

  3. EffectChainPresetManager: validate renamed preset names

    @Be-ing
    Be-ing committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    d0eda1b View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Merge branch 'main' of github.com:mixxxdj/mixxx into effects_refactoring

    @Holzhaus
    Holzhaus committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    ee651f5 View commit details
    Browse the repository at this point in the history

  2. EffectChainPresetManager: Unsplit some strings to help translators

    @Holzhaus
    Holzhaus committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    dcbd9cd View commit details
    Browse the repository at this point in the history

  3. EffectChainPresetManager: Use toByteArray to write XML document 

    Co-authored-by: Daniel Schürmann <daschuer@mixxx.org>
    @Holzhaus @daschuer
    Holzhaus and daschuer authored Apr 23, 2021
    Configuration menu
    Copy the full SHA
    b55c56a View commit details
    Browse the repository at this point in the history

  4. EffectChainPresetManager: Add various string fixes

    @Holzhaus
    Holzhaus committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    17f42fc View commit details
    Browse the repository at this point in the history

  5. EffectChainPresetManager: Rename effectSupported to effectAvailable

    @Holzhaus
    Holzhaus committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    7331d21 View commit details
    Browse the repository at this point in the history

  6. EffectChainPresetManager: Fix trailing whitespace

    @Holzhaus
    Holzhaus committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    6883735 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2021

  1. Merge branch 'main' of github.com:mixxxdj/mixxx into effects_refactoring

    @Holzhaus
    Holzhaus committed May 16, 2021
    Configuration menu
    Copy the full SHA
    790364e View commit details
    Browse the repository at this point in the history

  2. EffectChainPresetManager: Remove redudant file.close()

    @Holzhaus
    Holzhaus committed May 16, 2021
    Configuration menu
    Copy the full SHA
    cce1568 View commit details
    Browse the repository at this point in the history

  3. EffectChainPresetManager: Return if preset deletion fails

    @Holzhaus
    Holzhaus committed May 16, 2021
    Configuration menu
    Copy the full SHA
    11e4b12 View commit details
    Browse the repository at this point in the history

  4. EffectChainPresetManager: Replace toString().toUtf8() with toByteArray()

    @Holzhaus
    Holzhaus committed May 16, 2021
    Configuration menu
    Copy the full SHA
    cbc2acd View commit details
    Browse the repository at this point in the history

  5. EffectChainPresetManager: Continue on invalid preset name during import

    @Holzhaus
    Holzhaus committed May 16, 2021
    Configuration menu
    Copy the full SHA
    97ada3f View commit details
    Browse the repository at this point in the history

  6. EffectChainPresetManager: Rename "SavedPresets" to "UserPresets"

    @Holzhaus
    Holzhaus committed May 16, 2021
    Configuration menu
    Copy the full SHA
    9980147 View commit details
    Browse the repository at this point in the history

  7. EffectChainPresetManager: Show QFile.errorString() where applicable

    @Holzhaus
    Holzhaus committed May 16, 2021
    Configuration menu
    Copy the full SHA
    6161a39 View commit details
    Browse the repository at this point in the history

  8. EffectManifestParameter: Make setParameterType() private

    @Holzhaus
    Holzhaus committed May 16, 2021
    Configuration menu
    Copy the full SHA
    3a32979 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. DlgPrefEffects: Fix unitialized member in constructor

    @Holzhaus
    Holzhaus committed May 18, 2021
    Configuration menu
    Copy the full SHA
    280b936 View commit details
    Browse the repository at this point in the history

  2. EffectPreset: Ensure that all members are initialized in constructor

    @Holzhaus
    Holzhaus committed May 18, 2021
    Configuration menu
    Copy the full SHA
    f1d1326 View commit details
    Browse the repository at this point in the history

  3. EffectChainMixMode: Add kNumModes constant

    @Holzhaus
    Holzhaus committed May 18, 2021
    Configuration menu
    Copy the full SHA
    4de0539 View commit details
    Browse the repository at this point in the history

  4. EffectChainPreset: Fix uninitialized members in constructor

    @Holzhaus
    Holzhaus committed May 18, 2021
    Configuration menu
    Copy the full SHA
    3965be9 View commit details
    Browse the repository at this point in the history

  5. EffectSlot: Simplify code using helper variable

    @Holzhaus
    Holzhaus committed May 18, 2021
    Configuration menu
    Copy the full SHA
    b949bc0 View commit details
    Browse the repository at this point in the history

  6. EffectChainPresetManager: Use homePath instead of cwd for file dialog

    @Holzhaus
    Holzhaus committed May 18, 2021
    Configuration menu
    Copy the full SHA
    ebfc297 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. EffectManifestParameter: Fix enum class base type and member naming

    @Holzhaus
    Holzhaus committed May 19, 2021
    Configuration menu
    Copy the full SHA
    897fab1 View commit details
    Browse the repository at this point in the history

  2. EffectXml: Add missing k prefix

    @Holzhaus
    Holzhaus committed May 19, 2021
    Configuration menu
    Copy the full SHA
    aee13df View commit details
    Browse the repository at this point in the history

  3. VisibleEffectsList: Use QT_FORWARD_DECLARE_CLASS macro

    @Holzhaus
    Holzhaus committed May 19, 2021
    Configuration menu
    Copy the full SHA
    e83bd83 View commit details
    Browse the repository at this point in the history

  4. EffectsBackendManager: Use kNoEffectString instead of "None"

    @Holzhaus
    Holzhaus committed May 19, 2021
    Configuration menu
    Copy the full SHA
    3f145d2 View commit details
    Browse the repository at this point in the history

  5. EffectsBackendManager: Add warning if manifest was not found

    @Holzhaus
    Holzhaus committed May 19, 2021
    Configuration menu
    Copy the full SHA
    3d88d79 View commit details
    Browse the repository at this point in the history

  6. WEffectParameterNameBase: Use kNoEffectString instead of "None"

    @Holzhaus
    Holzhaus committed May 19, 2021
    Configuration menu
    Copy the full SHA
    99f3967 View commit details
    Browse the repository at this point in the history

  7. EffectChainPresetManager: Add missing error handling

    @Holzhaus
    Holzhaus committed May 19, 2021
    Configuration menu
    Copy the full SHA
    4d3d089 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2021

  1. QuickEffectChain: add comment for unintuitive code

    @Be-ing
    Be-ing committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    d22df2c View commit details
    Browse the repository at this point in the history

  2. EffectChainPresetListModel: validate dropped text

    @Be-ing
    Be-ing committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    cc9f918 View commit details
    Browse the repository at this point in the history

  3. Tango/LateNight: fix merge conflicts

    @Be-ing
    Be-ing committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    6cde58a View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into effects_refactoring 

    FIXME: QML effects Controls are broken
    @Be-ing
    Be-ing committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    381c411 View commit details
    Browse the repository at this point in the history

  5. EffectChainPresetManager: automatically rename duplicate presets 

    instead of prompting user to rename. The user can rename later if
they want.
    @Be-ing
    Be-ing committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    686314c View commit details
    Browse the repository at this point in the history

  6. EffectChainPresetManager: immediately copy imported preset files 

    This is required for renaming to work before restarting Mixxx. Also,
this ensures that the preset file is saved in case Mixxx does not
shut down cleanly.
    @Be-ing
    Be-ing committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    207a904 View commit details
    Browse the repository at this point in the history

  7. EffectChain: factor out + 1 to separate function

    @Be-ing
    Be-ing committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    49f1a26 View commit details
    Browse the repository at this point in the history

  8. QML: Fix broken effects integration 

    Unfortunately, the whole QML effects integration was broken by PR mixxxdj#2618.
This commit restores it, but it shows that the new API is still far from
optimal and needs additional work. This can be taken care of in
subsequent PRs.
    @Holzhaus
    Holzhaus committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    e1132b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2021

  1. EffectChainPresetManager: use while loop for duplicate presets

    @Be-ing
    Be-ing committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    6d6ea72 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    c7fc756 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Jul 31, 2021
    Configuration menu
    Copy the full SHA
    ab4d3dd View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Aug 1, 2021
    Configuration menu
    Copy the full SHA
    aeadc65 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    bf25de6 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    2b9140a View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    8baa8c3 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    1c7f7e7 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    8bc19b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    01a61a9 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    f5864c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    67f35d0 View commit details
    Browse the repository at this point in the history

  2. built-in effects: use constexpr instead of const

    @Be-ing
    Be-ing committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    4d7bde1 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    f58f68e View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    f8f6260 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    c462211 View commit details
    Browse the repository at this point in the history

  2. EffectChainPresetListModel: fix validation of dropped text 

    Before, the dropped text was checked if it was in the user's set
of presets for the standard effect chains. That broke dropping
presets in the QuickEffect list that were not in the standard
effect chain preset list and also broke dragging and dropping
presets from the QuickEffect list to the standard chain preset
list.
    @Be-ing
    Be-ing committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    de8b3a4 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    ebec5ef View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    681e375 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    0cb59e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    60087aa View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    3cd6a93 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    d967eec View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    e4e8cc8 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    ef6e73d View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    02e7b6a View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    5d3d57d View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    c4ad6b1 View commit details
    Browse the repository at this point in the history

  2. Rename loaded_effect related variables to match the CO name

    @daschuer @Be-ing
    daschuer authored and Be-ing committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    196bb7d View commit details
    Browse the repository at this point in the history

  3. Remove redundant check in loadEffectWithDefaults()

    @daschuer @Be-ing
    daschuer authored and Be-ing committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    c3a15e0 View commit details
    Browse the repository at this point in the history

  4. Remove redundant copy of default constructed EffectParameterPreset

    @daschuer @Be-ing
    daschuer authored and Be-ing committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    e145a38 View commit details
    Browse the repository at this point in the history

  5. Exit effect parameter presets loop once we have a match to save some … 

    …CPU cycles
    @daschuer @Be-ing
    daschuer authored and Be-ing committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    199637b View commit details
    Browse the repository at this point in the history

  6. Added missing 0 set of loaded_effect when it has been unloaded

    @daschuer @Be-ing
    daschuer authored and Be-ing committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    06b3f2b View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    4141b2d View commit details
    Browse the repository at this point in the history

  8. Ignore 0 in EffectChain::slotControlChainSelector to match the behavi… 

    …or in EffectSlot::slotEffectSelector
    @daschuer @Be-ing
    daschuer authored and Be-ing committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    8b9d712 View commit details
    Browse the repository at this point in the history

  9. Simplify control flow in loadChainPreset

    @daschuer @Be-ing
    daschuer authored and Be-ing committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    d385385 View commit details
    Browse the repository at this point in the history

  10. Remove redundant setting of m_pControlLoadedChainPreset

    @daschuer @Be-ing
    daschuer authored and Be-ing committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    445e9b8 View commit details
    Browse the repository at this point in the history

  11. Remove pointless check if group is empty.

    @daschuer @Be-ing
    daschuer authored and Be-ing committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    faaa80f View commit details
    Browse the repository at this point in the history

  12. EffectChain: do not reload preset when chain_selector set to 0

    @Be-ing
    Be-ing committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    1a5d702 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2021

  1. EffectChain: fix inconsistent ControlObject names & add aliases

    @Be-ing
    Be-ing committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    83790ed View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    900bf6b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    864c682 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    4793f7b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    8a70023 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. Merge remote-tracking branch 'upstream/main' into effects_refactoring

    @Be-ing
    Be-ing committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    c9d4bb0 View commit details
    Browse the repository at this point in the history