Fix Preferences Buttons #2664
Merged
Fix Preferences Buttons #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
reviewed
Apr 15, 2020
Be-ing
reviewed
Apr 15, 2020
| @@ -17,16 +17,18 @@ class DlgPrefColors : public DlgPreferencePage, public Ui::DlgPrefColorsDlg { | |||
| virtual ~DlgPrefColors(); | |||
|
|
|||
| public slots: | |||
| // Apply changes to widget | |||
| /// Called when the preference dialog (not this page) is shown to the user. | |||
There was a problem hiding this comment.
Do we really need to copy documentation from parent classes into every derived class?
There was a problem hiding this comment.
No, but it doesn't hurt either. I just replaced the already existing comments with better ones.
Be-ing
reviewed
Apr 15, 2020
Be-ing
reviewed
Apr 15, 2020
Be-ing
reviewed
Apr 15, 2020
Be-ing
reviewed
Apr 16, 2020
|
Thank you for taking care of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of pages don't implement
slotCancelandslotResetToDefaults.I implemented
slotResetToDefaultsfor the colors and the controller pages and added a defaultslotCancelimplementation that falls back toslotUpdate.To prevent situations like this in the future, I deleted the default implementation for
slotUpdate/slotApply/slotResetToDefaultso that pages have to implement them.For the LV2 page I added empty functions with a
TODOcomment for now, since I don't have any LV2 plugins and can't test it.