Add "Last Played" column to library #2670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st played time for every track. https://bugs.launchpad.net/mixxx/+bug/1490818 This initial version doesn't respond to changes in the playlist, but it does do the initial population at startup.
|
Also, bindValue isn't work for some reason. I'll try it again but it keeps saying "parameter count mismatch" even though everything looks right. |
Be-ing
reviewed
Apr 16, 2020
|
pushed a change that tries to use bindValue but it fails. Can't figure out why, but the prepare statement seems to be returning false |
VIEWs can't use params.
|
ok bindvalue works now |
|
Build fails: |
Be-ing
reviewed
Apr 17, 2020
|
It works, cool! I'll let others review the implementation details. |
uklotzde
reviewed
Apr 17, 2020
Split lastplayed helpers into two separate objects, one to create the table and the other to read from it. They are used by different parts of the code and need access to different things.
|
Fixed an issue where deleting a playlist did not correctly update the tables. I also did a drive-by change to the trackdeleted signal, which had a "position" parameter that was never used. |
ywwg
changed the title
uklotzde
reviewed
Sep 13, 2020
| @@ -88,7 +88,7 @@ void BaseSqlTableModel::initSortColumnMapping() { | |||
| m_columnIndexBySortColumnId[TrackModel::SortColumnId::SORTCOLUMN_DATETIMEADDED] = fieldIndex(ColumnCache::COLUMN_LIBRARYTABLE_DATETIMEADDED); | |||
| m_columnIndexBySortColumnId | |||
| [TrackModel::SortColumnId::SORTCOLUMN_LASTPLAYEDDATETIME] = | |||
| fieldIndex(ColumnCache::COLUMN_LASTPLAYED_DATETIMEPLAYED); | |||
| fieldIndex(ColumnCache::COLUMN_LIBRARYTABLE_DATETIMEPLAYED); | |||
There was a problem hiding this comment.
Commits in the history that do not even build are bad for git bisect. Redo and force push.
|
obsoleted by #3140 |
This was referenced Aug 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/mixxx/+bug/1490818
This adds an artificial column (the product of a simple TEMPORARY VIEW query) that reports the last time a track was played according to the history playlists.
This mostly works, except if I delete an old history playlist sometimes the library view is slow to show the updated values.