Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix qHash definitions #2762

Merged
merged 7 commits into from
May 16, 2020
Merged

Fix qHash definitions #2762

merged 7 commits into from
May 16, 2020

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented May 8, 2020 •
edited
Loading

  • The optional seed = 0 parameter in overloaded qHash() functions was missing
  • qHash() for AudioPath ignored m_channelGroup
  • Functions for AudioInput/-Output were undefined and unused

Now Mixxx crashes on exit when a MIDI controller is connected The crash is caused by #2767.

@uklotzde uklotzde changed the title Fix qHash definitions [WiP] Fix qHash definitions May 8, 2020
@uklotzde uklotzde changed the title [WiP] Fix qHash definitions Fix qHash definitions May 13, 2020
daschuer
daschuer approved these changes May 16, 2020
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit adef9be into mixxxdj:master May 16, 2020
@uklotzde uklotzde deleted the qhash branch May 17, 2020 09:38
@uklotzde uklotzde mentioned this pull request May 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus left review comments

@Be-ing Be-ing Be-ing left review comments

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uklotzde @daschuer @Holzhaus @Be-ing