Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lp1879656 Track info: Show file name for tracks without artist&title #2807

Merged
merged 5 commits into from
May 20, 2020
Merged

lp1879656 Track info: Show file name for tracks without artist&title #2807

merged 5 commits into from
May 20, 2020

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde requested review from Holzhaus and ronso0 May 20, 2020 21:17
@uklotzde uklotzde changed the base branch from master to 2.3 May 20, 2020 21:17
@uklotzde uklotzde added this to the 2.3.0 milestone May 20, 2020
@uklotzde uklotzde added the ui label May 20, 2020
daschuer
daschuer approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Unfortunately users Paring the window title for broadcasting need to adjust the parser.
But that is OK, since we are not in the beta period.

@daschuer
Copy link
Member

The pre-comit hook fails in res/skins/Deere/deck_text_row.xml because of a trailing white space.
That does not matter.

@daschuer daschuer merged commit 5264547 into mixxxdj:2.3 May 20, 2020
@daschuer
Copy link
Member

@uklotzde: Can you also add a changelog entry? This is a significant change for window headline paring useres.

@Holzhaus
Copy link
Member

The pre-comit hook fails in res/skins/Deere/deck_text_row.xml because of a trailing white space.
That does not matter.

Was this issue introduced in this PR? We shouldn't merge PRs with issues like these. Now the CI pre-commit job for every PR based on 2.3 will fail.

@uklotzde
Copy link
Contributor Author

I have run the pre-commit hook locally and it fixed line endings in 3 files. No idea why this now failed on CI? I'll fix the remaining issues with the CHANGELOG updates.

@uklotzde
Copy link
Contributor Author

@daschuer This string was buried deep inside the implementation as a plain literal without any documentation!!

@uklotzde
Copy link
Contributor Author

uklotzde commented May 21, 2020 •
edited
Loading

res/skins/Deere/deck_text_row.xml doesn't contain any whitespace or line ending issues. Instead these should have been fixed by this PR.

@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

@Holzhaus Holzhaus Awaiting requested review from Holzhaus

@ronso0 ronso0 Awaiting requested review from ronso0

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @daschuer @Holzhaus