Added a clang_format.py to check the whole PR on CI #2816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it be convenient to get this into 2.3? Dependent on if it is possible and feasible. |
daschuer
force-pushed
the
pre-commit-clang
branch
from
60c1327
to
5f5ee12
Compare
|
OK, now targeting 2.3 |
|
Can we merge this now? |
Holzhaus
reviewed
Jun 5, 2020
|
|
||
| cmd = ["git-clang-format"] | ||
|
|
||
| source_commit = os.environ.get("PRE_COMMIT_SOURCE") |
There was a problem hiding this comment.
I think this is called PRE_COMMIT_FROM_REF in current versions of pre-commit.
There was a problem hiding this comment.
This is the new v2.2.0 value the old value is still supported.
Mine is 2.0.1
|
Something is wrong, the pre-commit-pr job failed and tried to reformat multiple source files. |
|
Superseded by: #2981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue that the pre-commit hook test on Travis successes even if there are pending clang-format issues.
This was due to not check the files and the PRE_COMMIT_SOURCE environment variable.
This PR fixes this.