Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell.nix: Update from scons to cmake #2820

Merged
merged 2 commits into from
May 27, 2020
Merged

Conversation

haslersn
Copy link
Contributor

No description provided.

@Be-ing
Copy link
Contributor

Be-ing commented May 27, 2020

@poelzi could you review this?

@Holzhaus Holzhaus added the build label May 27, 2020
@Holzhaus Holzhaus added this to the 2.4.0 milestone May 27, 2020
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Be-ing
Copy link
Contributor

Be-ing commented May 27, 2020

@matthiasbeyer thanks. I'll take your word for it because I don't know much about Nix.

@Be-ing Be-ing merged commit fac73cd into mixxxdj:master May 27, 2020
@uklotzde
Copy link
Contributor

Thank you, Matze :)

@haslersn haslersn deleted the nix_shell_cmake branch May 27, 2020 21:15
@matthiasbeyer
Copy link
Contributor

Yeah it all looks pretty straight-forward, no daemons that I can see, so I figured I just ACK this and maybe that's enough for you guys! ❤️

@poelzi
Copy link
Contributor

poelzi commented May 28, 2020

I don't understand the change from default.nix to shell.nix. I use nix-build to produce a nix derivate which i use daytoday. I use nix-shell to get a build environment. Your change destroys my first use case while providing no benefits.

@matthiasbeyer
Copy link
Contributor

matthiasbeyer commented May 28, 2020

no, nix-shell automatically uses shell.nix and if that's not available default.nix, but default.nix can also be used to package the repo without any further investigation.

Executing nix-shell should have the same effect before this change and after this change.

Edit:

Building should afaik still be possible using nix-build ./shell.nix then... not sure though, maybe @haslersn knows?

@haslersn
Copy link
Contributor Author

haslersn commented May 28, 2020

I don't understand the change from default.nix to shell.nix. I use nix-build to produce a nix derivate which i use daytoday. I use nix-shell to get a build environment. Your change destroys my first use case while providing no benefits.

I understand that this change destroys your first use case. However, there is the benefit that lorri can now be used. AFAIK there is no simple workaround for lorri, but there is a simple workaround for your first use case: Just run

$ nix-build shell.nix
or:
$ nix build -f shell.nix

Note that you have to remove ccache from the build inputs for the Nix build to work. An obvious solution would be to have a separate default.nix for building the derivation. However, non-Nix people might dislike too many .nix files in the repo.

@haslersn
Copy link
Contributor Author

haslersn commented May 28, 2020

If it's okay with other maintainers to have two .nix files, then we can have a default.nix for building the derivation and a shell.nix which imports the default.nix with additional native build inputs [ ccache gdb git-clang-format shell-configure shell-build shell-run shell-debug ].

@haslersn
Copy link
Contributor Author

@poelzi Would this work for you: #2828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants