-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell.nix: Update from scons to cmake #2820
Conversation
@poelzi could you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@matthiasbeyer thanks. I'll take your word for it because I don't know much about Nix. |
Thank you, Matze :) |
Yeah it all looks pretty straight-forward, no daemons that I can see, so I figured I just ACK this and maybe that's enough for you guys! ❤️ |
I don't understand the change from default.nix to shell.nix. I use nix-build to produce a nix derivate which i use daytoday. I use nix-shell to get a build environment. Your change destroys my first use case while providing no benefits. |
no, Executing Edit: Building should afaik still be possible using |
I understand that this change destroys your first use case. However, there is the benefit that lorri can now be used. AFAIK there is no simple workaround for lorri, but there is a simple workaround for your first use case: Just run
Note that you have to remove |
If it's okay with other maintainers to have two |
No description provided.