Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell.nix: Add some missing dependencies #2836

Merged

Conversation

haslersn
Copy link
Contributor

@haslersn haslersn commented Jun 1, 2020

When using the nix-shell for installing dependencies, cmake (non-fatally) outputted that:

  • Could NOT find MP4v2
  • Could NOT find FFmpeg
  • Could NOT find Modplug
  • Could NOT find WavPack

This PR fixes it.

Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I do not care about proper attribution here... so go ahead! 😄

shell.nix Show resolved Hide resolved
@uklotzde
Copy link
Contributor

uklotzde commented Jun 1, 2020

Looks reasonable, so LGTM.

@uklotzde uklotzde merged commit 30843da into mixxxdj:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants