controllers: Fix crash if controller mapping has no module #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two bugs that were caused by mixxxdj#2868: 1. Mixxx didn't check if the JS module path was really a file. If you pass in a directory, QtJSEngine::importModule makes Mixxx crash (at least on Qt 5.15.0) 2. If a mapping does not have JS module associated with it, then the moduleFileInfo always pointed to the controller directory and hence triggered bug 1. This fixes both of these issues and adds some debug assertions to make sure it stays like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs that were caused by #2868:
you pass in a directory, QtJSEngine::importModule makes Mixxx
crash (at least on Qt 5.15.0)
moduleFileInfo always pointed to the controller directory and
hence triggered bug 1.
This fixes both of these issues and adds some debug assertions to make
sure it stays like that.