New Beats with UI [GSoC 2020] #2961
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update "New Beats with UI" PR to latest main
|
GitHub is confused and doesn't show the CI results properly. They are still accessible here: https://github.com/hacksdump/mixxx/actions/runs/614728642 |
Merged
Draft
This was referenced Mar 17, 2021
Merged
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
the
stale
|
I see this is no longer in the 2.4 milestone, but some features have been incorporated as other PRs - what's the timeline for downbeat markers in mixxx currently? The PR history is long and confusing from a potential contributor POV. |
|
You may take a look at #4489 and Jan's other PRs |
github-actions
bot
removed
the
stale
This was referenced Aug 22, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR history:
#2861 (Continuation of #2512)
#2844
Beatgrid editing operations for editing BPM (variable) and Time Signature (variable) will be implemented in this PR. The backend and GUI will be simultaneously developed.
TODO:
Edit time signature at arbitrary downbeats.
Edit BPM at arbitrary beats.
Hybridise BeatGrid and BeatMap implementations to allow beat jump before track.
Fix TimeSignatureShouldNotChangeBpm Test.
Write more tests for new code.
Improve editing UX.
The leftmost beat disappears too early when waveform scrolls. The features such as markers and downbeat triangles should be visible even if the beat is not on screen.
Use interbeat distance to eliminate beats.