Stream_name: Adding a default stream name to the Stream Info.

[PawBud]

This PR aims to fix https://bugs.launchpad.net/mixxx/+bug/1818054.

Discussion on Zulip: https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/adding.20a.20default.20Stream.20Name.

[ronso0]

This is a harmless bug fix so you can target mixxx:2.3 instead of master.

There shouldn't be a need to rebase, but in case you see unrelated commits poping up here after you switched to mixxx:2.3, just run git rebase -i XXX/2.3 where XXX is what you named the mixxxdj/mixxx remote.

[ronso0]

Unfortunately users that upgraded Mixxx can't benefit from this fix instantly due to the following constraints (not caused by this branch):

1. I expected "Create new connection" in Pref > Broadcast to create a new connection from the default profile, but it just copies the existing connection. That was discussed only briefly in Multi-broadcasting #1300 (comment).
   As @Palakis mentioned, we shoul dhave Clone (selected) connection and Create new (default) connection
2. Reset to defaults does nothing (on purpose), but this too inhibits getting a fresh default connection
3. last connection cannot be deleted

All in all, users can not get a default connection again after altering the initial settings unless they remove all connection files from $CONFIG_DIR/broadcast_profiles manually.

EDIT
3. was already touch in #2158 bu not considered worth fixing

[PawBud]

Unfortunately users that upgraded Mixxx can't benefit from this fix instantly due to the following constraints (not caused by this branch):

1. I expected "Create new connection" in Pref > Broadcast to create a new connection from the default profile, but it just copies the existing connection. That was discussed only briefly in #1300 (comment).
   As @Palakis mentioned, we shoul dhave Clone (selected) connection and Create new (default) connection
2. Reset to defaults does nothing (on purpose), but this too inhibits getting a fresh default connection
3. last connection cannot be deleted

All in all, users can not get a default connection again after altering the initial settings unless they remove all connection files from $CONFIG_DIR/broadcast_profiles manually.

EDIT
3. was already touch in #2158 bu not considered worth fixing

So, bottom line, do I have to wait until a Fix is issued, although you clearly stated that they r not really "bugs", I think I will work on another issue for the time being, if that's ok?

[ronso0]

never mind, as I wrote it's unrelated to your fix, just a heads-up for everyone reading this.
Users starting with a new Mixxx install (or clean config) will get the stream name filled.

This is a harmless bug fix so you can target mixxx:2.3 instead of master.

This can be done at the top of this page, 'Edit', then select mixxx/2.3 in the drop-down.

There shouldn't be a need to rebase, but in case you see unrelated commits poping up here after you switched to mixxx:2.3, just run git rebase -i XXX/2.3 where XXX is what you named the mixxxdj/mixxx remote.

[PawBud]

@ronso0 so the thing is I picked the commits (and didn't squash any), It should rebase but it's showing some conflicts, I tried to manually Accept Incoming Changes and merged them with the commit message as Resolving Conflicts in VSC, but it just kept on aborting. What am I doing wrong?

[Holzhaus]

Please follow the instructions here: https://github.com/mixxxdj/mixxx/wiki/Using%20Git#targeting-another-base-branch

[PawBud]

Please follow the instructions here: https://github.com/mixxxdj/mixxx/wiki/Using%20Git#targeting-another-base-branch

just what I needed! Thanks a lot, I ll remember the command from now on I guess :).

[PawBud]

@ronso0, It's weird that the default string is not showing up:-

[ronso0]

I guess that's exactly what I discovered above

Try removing all files from $CONFIG_DIR/broadcast_profiles (~/.mixxx/broadc.. on linux), or remove/backup the config dir entirely.
Then it shows up for the initial default new connection.

[PawBud]

I guess that's exactly what I discovered above

Try removing all files from $CONFIG_DIR/broadcast_profiles (~/.mixxx/broadc.. on linux), or remove/backup the config dir entirely.
Then it shows up for the initial default new connection.

I can't really find the config directory, there is a file mixxx\.tx\config and a config log, Is this it?

[ronso0]

Wiki: Finding the mixxx.log file
In that dir there's also a broadcast_profiles directory.

[PawBud]

It's pretty embarrassing to further ask your help, but I can't find any file named mixxx.log, moreover, I have verified that there are no Hidden dir.

[Holzhaus]

The hidden .mixxx directory is in your home directory.

[ronso0]

Please read Wiki: Finding the mixxx.log file
There's a .mixxx folder in you Home directory, like home/YourUsername/.mixxx/
Make sure you have 'Show hidden folder' enabled for your file manager.

[ronso0]

(I update the wiki page to include that info)

[PawBud]

oh ok thanks a lot, should be easier for others now :)
Update: Done! I verified it, why are the tests failing though

[ronso0]

Any comments on the minimal changes? If not I'd merge this.

[daschuer]

@PawBud: Thank you for this fist pull request.

Before merge we need you permission.
Please sign:
https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ
and comment here when done.

[daschuer]

LGTM. (the CI failure is unrelated.)

[PawBud]

Done @daschuer

[daschuer]

Thank you.

[daschuer]

6c5bc4d43d2