Search related tracks in collection #3181

uklotzde · 2020-10-17T19:49:56Z

A simple yet effective extension of the track context menu for exploring and managing the library:

Searching for tracks with a similar tempo would be another option.

I have created this feature for personal usage and will not extend it myself, i.e. only provided as a starting point.

uklotzde · 2020-10-17T21:56:19Z

The CI test failures on Windows are unrelated. @Holzhaus Maybe caused by recent float fixes? These failures seem to become more frequent.

uklotzde · 2020-10-17T22:44:15Z

I must have created a Launchpad issue a long time ago: https://bugs.launchpad.net/mixxx/+bug/1455901

uklotzde · 2020-10-17T23:34:36Z

Update and extended. BPM and year can be added by someone else who needs it.

ronso0 · 2020-10-17T23:38:37Z

Update and extended. BPM and year can be added by someone else who needs it.

So this could be extended to 'fuzzy BPM search' like +- 5 BPM?

uklotzde · 2020-10-17T23:41:40Z

Update and extended. BPM and year can be added by someone else who needs it.

So this could be extended to 'fuzzy BPM search' like +- 5 BPM?

Sure. Just a few lines of code. But I am not keen on discussions about the actual range and configuration options, therefore left out in this PR.

The year is also tricky, because this is a string field. Parsing the string to a date is part of the aoide PR, I already had to do that. Too lazy to backport it.

ronso0 · 2020-10-17T23:45:54Z

Update and extended. BPM and year can be added by someone else who needs it.

So this could be extended to 'fuzzy BPM search' like +- 5 BPM?

Sure. Just a few lines of code. But I am not keen on discussions about the actual range and configuration options, therefore left out in this PR.

Sure.

The year is also tricky, because this is a string field. Parsing the string to a date is part of the aoide PR, I already had to do that. Too lazy to backport it.

Could you please share link to the code that does it?

uklotzde · 2020-10-17T23:53:35Z

Update and extended. BPM and year can be added by someone else who needs it.

So this could be extended to 'fuzzy BPM search' like +- 5 BPM?

Sure. Just a few lines of code. But I am not keen on discussions about the actual range and configuration options, therefore left out in this PR.

Sure.

The year is also tricky, because this is a string field. Parsing the string to a date is part of the aoide PR, I already had to do that. Too lazy to backport it.

Could you please share link to the code that does it?

mixxx/src/test/aoide_trackexporter_test.cpp

Line 31 in bdb0160

TEST_F(AoideTrackExporterTest, exportDateTimeOrYear) {

The tests are both the starting point and crucial!!

poelzi · 2020-10-18T00:32:52Z

Lastfm has a query similar api that returns artists with similar style. If we could form a or query, that might be interesting. Or we implement this as some fancy filter for the search query. lastfm_similar("Bakermat") would be replaced with some large artist in ['...', '..', '...', ] query. It seems you can't combine like with in.

uklotzde · 2020-10-18T00:34:30Z

Lastfm has a query similar api that returns artists with similar style. If we could form a or query, that might be interesting. Or we implement this as some fancy filter for the search query. lastfm_similar("Bakermat") would be replaced with some large artist in ['...', '..', '...', ] query. It seems you can't combine like with in.

Extending the query capabilities is out of scope of this PR.

uklotzde · 2020-10-18T00:39:56Z

If this PR is not reviewed in-time I will delete it and keep it as a commit in my private fork on top of all my other pending changes. The changes introduced here cause a lot of merge conflicts for me and I am not willing to resolve them for an extended period of time.

Holzhaus

Code looks good. I'll give this a try tomorrow.

Be-ing · 2020-10-18T09:17:52Z

I think there's room for a more innovative design that doesn't rely on navigating menus and right clicking (which isn't available on touch screens), but that can be added later as another interface for the same features. For now, adding this to WTrackMenu is an easy and obvious design for a big usability improvement, especially now that WTrackMenu is available in the decks.

src/widget/wtrackmenu.h

src/widget/wtrackmenu.cpp

uklotzde · 2020-10-18T10:18:35Z

I need to force push to fix a preceding PR that contains unintended changes caused by conflict resolution while cherry-picking.

uklotzde · 2020-10-18T10:20:19Z

I have also reordered and separated the menu items:

Musical properties
Artists
Anything else

Holzhaus · 2020-10-20T11:25:39Z

Unfortunately the key search depends on the notation chosen in the preferences and won't work in all cases. For "Lancelot" it works, but for "Lancelot/Traditional" it doesn't.

The key text parsing is done by KeyUtils::guessKeyFromText. I haven't checked if this works as expected, out of scope. The text is provided by the Track object and should match the user's preferences.

TL;DR: I will not fix the key search, provided as is.

I think it's just a quoting issue. ~key:7A works, ~key:7A (Dm) does not. Adding quotes fixes it: ~key:"7A (Dm)".

ronso0 · 2020-10-20T13:33:23Z

@ALL Please provide feedback on the ordering and formatting of the menu and its items. This is what matters most in the first place.

The first 2 and the last 3 are probably the most useful, and I find elements at the top or end of a list easier to find quickly than in the middle of a list.

I'd use BPM and Artist the most, and I think searching for Title is used rarely.
So I'd swap the Artist/Album Artist and Title/ Album Title rows:

Key
BPM
-----
Artist
Album Artist
Title
Album
-----
Year
Genre
Folder

uklotzde · 2020-10-20T13:59:20Z

Unfortunately the key search depends on the notation chosen in the preferences and won't work in all cases. For "Lancelot" it works, but for "Lancelot/Traditional" it doesn't.

The key text parsing is done by KeyUtils::guessKeyFromText. I haven't checked if this works as expected, out of scope. The text is provided by the Track object and should match the user's preferences.
TL;DR: I will not fix the key search, provided as is.

I think it's just a quoting issue. ~key:7A works, ~key:7A (Dm) does not. Adding quotes fixes it: ~key:"7A (Dm)".

Thanks for the hint! I have recently removed the quotes because I thought they were not needed 🙈 Will re-add them.

uklotzde · 2020-10-20T14:35:33Z

Unfortunately the key search depends on the notation chosen in the preferences and won't work in all cases. For "Lancelot" it works, but for "Lancelot/Traditional" it doesn't.

The key text parsing is done by KeyUtils::guessKeyFromText. I haven't checked if this works as expected, out of scope. The text is provided by the Track object and should match the user's preferences.
TL;DR: I will not fix the key search, provided as is.

I think it's just a quoting issue. ~key:7A works, ~key:7A (Dm) does not. Adding quotes fixes it: ~key:"7A (Dm)".

Fixed.

uklotzde · 2020-10-20T14:35:57Z

@ALL Please provide feedback on the ordering and formatting of the menu and its items. This is what matters most in the first place.

The first 2 and the last 3 are probably the most useful, and I find elements at the top or end of a list easier to find quickly than in the middle of a list.

I'd use BPM and Artist the most, and I think searching for Title is used rarely.
So I'd swap the Artist/Album Artist and Title/ Album Title rows:
Key
BPM
-----
Artist
Album Artist
Title
Album
-----
Year
Genre
Folder

Done.

Holzhaus

LGTM, thank you!

src/widget/wsearchrelatedtracksmenu.cpp

Be-ing · 2020-10-24T19:12:47Z

src/widget/wsearchrelatedtracksmenu.cpp

+    // Title and grouping actions
+    addSeparatorBeforeNextAction = !isEmpty();
+    {
+        const auto title = track.getTitle();


How about searching for trailing text in parentheses and adding another menu entry without that? I think that would work for the remix/original searches in most cases. For example, if the title is "Foo (Bar Remix)", add items to search both title:"Foo (Bar Remix)" and title:"Foo"

There are too many variations. I leave this (and the following discussion) to a subsequent PR after we collected some feedback.

Feel free to start working on a class TitleParser that will be needed for this purpose ;)

Be-ing · 2020-10-24T19:51:38Z

Thanks for working on this!

ronso0 · 2020-10-25T03:05:59Z

👍 in conjunction with Remove from Disk #3212 this is a killer tool for cleaning up my library!

only the location string shown in the Folder: : is that needed? it expands the menu a lot.

uklotzde · 2020-10-25T13:13:17Z

+1 in conjunction with Remove from Disk #3212 this is a killer tool for cleaning up my library!

only the location string shown in the Folder: : is that needed? it expands the menu a lot.

That's exactly the reason why we need an MVP of every new feature for collecting early feedback instead of getting lost in detailed discussions about potential edge cases ;) Work continues in #3215

ronso0 · 2020-10-25T14:49:05Z

for everyone who like me has to lookup MVP: minimum viable product

uklotzde added the library label Oct 17, 2020

uklotzde added this to the 2.4.0 milestone Oct 17, 2020

Holzhaus reviewed Oct 18, 2020

View reviewed changes