Merge 2.3 into main: HotcueControl

[uklotzde]

Individual setters/getters break encapsulation and are an anti-pattern. I have replaced them with use case related functions to resolve the merge conflicts:

• HotcueControl::canPreview()
• HotcueControl::isPreviewing()
• HotcueControl::startPreviewing()
• HotcueControl::stopPreviewing()

Please check if the side-effect --m_iCurrentlyPreviewingHotcues in the else if arm in CueControl::hotcueActivatePreview() is correct! I am unsure about the order of evaluation. We should try to avoid such brittle code tricks.

[daschuer]

I have pushed a merge commit in the mean time.
I have also a follow up branch that fixes reviewing. It is broken anyway.
Can we hold your changes back until this is solved and then re-base them onto the fix?
It is anyway not a good idea to hide refactoring in a merge commit.

[uklotzde]

I have pushed a merge commit in the mean time.
I have also a follow up branch that fixes reviewing. It is broken anyway.
Can we hold your changes back until this is solved and then re-base them onto the fix?
It is anyway not a good idea to hide refactoring in a merge commit.

Sure

[daschuer]

See: #3382