Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi Preview Fix #3382

Merged
merged 21 commits into from
Jan 5, 2021
Merged

Multi Preview Fix #3382

merged 21 commits into from
Jan 5, 2021

Commits on Nov 29, 2020

  1. Only allow one previewing hotcue at the time. This is required for a … 

    …consitent transition between loop cues and hot cues.
    @daschuer
    daschuer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    58310ee View commit details
    Browse the repository at this point in the history

  2. discard cued seek action after a new track has been loaded

    @daschuer
    daschuer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    5fd6d41 View commit details
    Browse the repository at this point in the history

  3. Remove redundant handling of the Main cue

    @daschuer
    daschuer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    10f9e9d View commit details
    Browse the repository at this point in the history

  4. Improve locking

    @daschuer
    daschuer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    9f1b93c View commit details
    Browse the repository at this point in the history

  5. Add function overload to createAndAddCue() to initalize the cue as well

    @daschuer
    daschuer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    8b0614d View commit details
    Browse the repository at this point in the history

  6. Add Cue::setStartAndEndPosition() for setting both under one locking … 

    …scope
    @daschuer
    daschuer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    3e6775a View commit details
    Browse the repository at this point in the history

  7. Create and initalize Cues at once to avoid sending singlas with halve… 

    … initalized data
    @daschuer
    daschuer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    39ff078 View commit details
    Browse the repository at this point in the history

  8. get rid of hotCueFound

    @daschuer
    daschuer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    7159a99 View commit details
    Browse the repository at this point in the history

  9. remove now unused createAndAddCue() that creates an invalid Cue

    @daschuer
    daschuer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    234f90b View commit details
    Browse the repository at this point in the history

  10. Remove unused Cue() default constructor

    @daschuer
    daschuer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    c38fd68 View commit details
    Browse the repository at this point in the history

  11. make m_iHotCue const

    @daschuer
    daschuer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    15e10bb View commit details
    Browse the repository at this point in the history

  12. Added getStartAndEndPosition() to query both in one locking scope.

    @daschuer
    daschuer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    2d75861 View commit details
    Browse the repository at this point in the history

  13. Use getStartAndEndPosition() to be sure the two values match.

    @daschuer
    daschuer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    ffcb727 View commit details
    Browse the repository at this point in the history

  14. Improve API for storing of the inital preview state.

    @daschuer
    daschuer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    ad7a2b2 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. fix typos

    @daschuer
    daschuer committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    d72f2b4 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into hotcue_focus_off_by… 

    …_one_main
    @daschuer
    daschuer committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    bac1956 View commit details
    Browse the repository at this point in the history

  3. Make a local copy of m_pCurrentSavedLoopControl to make sur it doe no… 

    …t become null
    @daschuer
    daschuer committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    90342c4 View commit details
    Browse the repository at this point in the history

  4. rename storePreviewingActivateData() to cachePreviewingStartState() a… 

    …nd add a comment
    @daschuer
    daschuer committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    512573d View commit details
    Browse the repository at this point in the history

  5. Reorder member variables

    @daschuer
    daschuer committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    58f9939 View commit details
    Browse the repository at this point in the history

  6. swap if else logic

    @daschuer
    daschuer committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    4114b16 View commit details
    Browse the repository at this point in the history

  7. narrow locking scope

    @daschuer
    daschuer committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    ad9bddb View commit details
    Browse the repository at this point in the history