Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB: Do not add column last_played_at twice #3596

Merged
merged 1 commit into from
Jan 24, 2021
Merged

DB: Do not add column last_played_at twice #3596

merged 1 commit into from
Jan 24, 2021

Conversation

uklotzde
Copy link
Contributor

Probably introduced when resolving merge conflicts. Does not cause any issues other than a critical log on schema migration.

critical [Main] FwdSqlQuery - Failed to prepare "-- Add new column\n      ALTER TABLE library ADD COLUMN last_played_at DATETIME DEFAULT NULL" : QSqlError("1", "Unable to execute statement", "duplicate column name: last_played_at")

Test: New profile with empty database

@uklotzde uklotzde added this to the 2.4.0 milestone Jan 24, 2021
daschuer
daschuer approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thank you. LGTM.

@daschuer daschuer merged commit c8186ba into mixxxdj:main Jan 24, 2021
@uklotzde uklotzde deleted the column-last_played_at branch January 25, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
library
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @daschuer