Code

Eq rack2#364

Code

Merged

rryan merged 122 commits intomixxxdj:mastermixxxdj/mixxx:masterfrom daschuer:eq_rack2daschuer/mixxx:eq_rack2Copy head branch name to clipboardNov 16, 2014

+716-589

Commits

Commits on May 20, 2014

• Add eqeffect.cpp to sources list

  badescunicu

  committed
  bbf6999

• Create an effect with a 3 band EQ

  badescunicu

  committed
  458b8b7

Commits on May 21, 2014

• Register EqEffect

  badescunicu

  committed
  d91b153

• Fix comment

  badescunicu

  committed
  4c0d2fb

• [Coding Style] Each member of a class should be on its own line

  badescunicu

  committed
  5781325

• Remove the link between the super knob and eq knobs

  badescunicu

  committed
  2a4b063

• Use the initializer list for old_low, old_mid, old_high, old_dry

  badescunicu

  committed
  1299acb

Commits on May 23, 2014

• Use a ControlObjectSlave to get the sample rate from the EqEffect

  badescunicu

  committed
  5cb622f

• Make the sample rate accessible from descendants of GroupEffectProcessor

  badescunicu

  committed
  dd092b6

• Connect the frequency corners from preferences to the EQ Effect

  badescunicu

  committed
  e46bf37

• Initialize m_loFreq and m_hiFreq with 0 in initializer list

  badescunicu

  committed
  def4866

Commits on May 24, 2014

• Fix typo in control.h

  badescunicu

  committed
  16f52cb

Commits on May 30, 2014

• Do ramping after setFrequencyCorners() (not working properly yet)

  badescunicu

  committed
  2589688

• Do a cross fade without using an additional buffer (not working properly yet)

  badescunicu

  committed
  ee31d2e

Commits on Jun 1, 2014

• Do not create new filters in setFilters(). Update previously created filters instead.

  badescunicu

  committed
  d49aaa8

• Change the sample rate in setFrequencyCorners(). If frequency corners are changed, do ramping in the next process() call

  badescunicu

  committed
  8859eff

• Pass the sample rate to setFrequencyCorners()

  badescunicu

  committed
  03bdf87

Commits on Jun 2, 2014

• Use memset and memcpy for copying and initializing buffers

  badescunicu

  committed
  5890140

• Rename EqEffect to EQDefault

  badescunicu

  committed
  199146a

• Rename EQ knobs to LOW, MID and HIGH

  badescunicu

  committed
  4752eba

• Add descriptions to Default EQ and remove redundant includes

  badescunicu

  committed
  2d878c4

Commits on Jun 6, 2014

• Attempt at switch type parameters

  badescunicu

  committed
  ab66eee

Commits on Jun 16, 2014

• Update the underlying EffectParameter separately for each type of parameter

  badescunicu

  committed
  a61f12a

Commits on Jun 17, 2014

• Fix typo in computing m_maximum

  badescunicu

  committed
  df366e2

• Correct mistake in effectbuttonparameterslot

  badescunicu

  committed
  25559ed

Commits on Jun 19, 2014

• Add a new EffectRack with 4 EQDefault effects. Each EQ is responsible for a specific Channel

  badescunicu

  committed
  50ee860

• Fix comments

  badescunicu

  committed
  7122847

• Dynamic creation of EQ (each time a deck is added)

  badescunicu

  committed
  ee07447

Commits on Jun 20, 2014

• Pack the creation of a new EQ inside a method of EffectsManager

  badescunicu

  committed
  574d8ea

• Minor coding style improvement

  badescunicu

  committed
  0c9dabc

Commits on Jun 22, 2014

• Fix createElement argument in effect.cpp

  badescunicu

  committed
  f0bfd6f

Commits on Jun 26, 2014

• Add 4 check boxes for controlling which effect to load onto the EQ EffectRack

  badescunicu

  committed
  66bb4ed

• Pass a pointer to the EffectsManager to DlgPreferences

  badescunicu

  committed
  e8dcab8

• Update the Effects loaded onto the Rack when the user checks a box

  badescunicu

  committed
  4bf1845

Commits on Jun 27, 2014

• Use ControlObjectSlave instead of ControlObjectThread for setting the effect active and fully wet for a specific deck

  badescunicu

  committed
  9aeb025

• Add a slot inside EffectRack for loading an effect on an given effect slot of specific chain slot

  badescunicu

  committed
  e6f9f4d

• Add an EffectRack* and initialize it

  badescunicu

  committed
  06d34aa

• Create a new signal in dlgprefeq and connect it to a slot of the EQ Rack; use this signal whenever a change is made in preferences

  badescunicu

  committed
  615d2e9

• Remove the connection for CheckBoxes

  badescunicu

  committed
  c463b8f

• Create a slot inside dlgprefeq.cpp for dynamically creating ComboBoxes

  badescunicu

  committed
  2b18b73

• Temporary hack for having access to DlgPrefEQ

  badescunicu

  committed
  b87b610

• Add another ComboBox if the number of decks has increased

  badescunicu

  committed
  2f30f76

• Remove the hard coded check boxes

  badescunicu

  committed
  7a03def

• Dynamically update the required Deck with the selected Effect

  badescunicu

  committed
  eeb35dc

Commits on Jun 28, 2014

• Delete used QComboBoxes in destructor

  badescunicu

  committed
  5cda4b7

• Check if qobject_cast was successful

  badescunicu

  committed
  8b81768

• Maintain coding style consistency; remove additional empty lines

  badescunicu

  committed
  94177af

• Remove the hard coded check boxes from dlgprefeqdlg.ui

  badescunicu

  committed
  fb64948

• Connect [Master],num_decks' value changed signal to the slot which adds a QComboBox for each deck

  badescunicu

  committed
  776323c

• Remove the hard coded initialization of the EQ Effect Rack

  badescunicu

  committed
  f72071f

Commits on Jun 29, 2014

• Remove temporary hack for accessing DlgPrefEQ as it is no longer needed

  badescunicu

  committed
  872341d

• Add labels for each QComboBox

  badescunicu

  committed
  be04f6a

• Add a QLabel to dlgprefeqdlg.ui

  badescunicu

  committed
  9e4ef33

• Remove effect instantiation in addEffectChainSlotForEQ; now dlgprefeq.cpp is dictating when to load an effect

  badescunicu

  committed
  aa97b18

• Store user's configuration of the Effect Rack

  badescunicu

  committed
  657658b

Commits on Jun 30, 2014

• m_pConfig is deleted inside mixxx.cpp; this was causing an incorrect shutdown of Mixxx

  badescunicu

  committed
  b20cb78

• Introduce a check box for configuring the Effect Rack (basic/advanced view)

  badescunicu

  committed
  3fa8cc7

• Add a flag in EffectManifest to keep track if an effect is an Equalizer or not

  badescunicu

  committed
  b18c59e

• Add another method in EffectsManager class which returns the available Equalizers

  badescunicu

  committed
  babb40c

• Use getAvailableEQEffects inside DlgPrefEQ

  badescunicu

  committed
  5aef2b0

• Mark EQDefault as an EQ Effect

  badescunicu

  committed
  ce76dd8

• Add methods for retrieving the available effects names

  badescunicu

  committed
  a27f92a

• Use itemData() field for storing the effect ID. currentText() is stores the name of the current effect

  badescunicu

  committed
  80c960f

• Rename a couple of methods and variables

  badescunicu

  committed
  c7bfc2f

Commits on Jul 1, 2014

• Modify getAvailableEffectNames and getAvailableEQEffectNames to return a set of pairs containing the effect id and its name

  badescunicu

  committed
  bda0da7

• Use the newly modified methods to fix the link between combo box's text and its data

  badescunicu

  committed
  1e95377

Commits on Jul 2, 2014

• Instantiate controls needed by equalizers inside EffectsManager

  badescunicu

  committed
  fa36e3c

• Remove EngineFilterBlock from EngineDeck

  badescunicu

  committed
  b64f3cb

Commits on Aug 11, 2014

• Merge master and fix conflicts

  badescunicu

  committed
  2dbece9

• Mark Butterworth8EQEffect as an EQ Effect

  badescunicu

  committed
  afcc172

• Create aliases needed for the EQ Rack

  badescunicu

  committed
  b5c9f2f

Commits on Aug 13, 2014

• Use a loop to create aliases needed for the EQ rack

  badescunicu

  committed
  b89544d

• Merge branch 'master' of github.com:badescunicu/mixxx into eq_rack

  badescunicu

  committed
  6cc37d4

• Remove the radio buttons from EQ Preferences and enable internal EQ

  badescunicu

  committed
  6c59fa0

• Remove EngineFilterBlock

  badescunicu

  committed
  d016e61

Commits on Aug 14, 2014

• Add a Bypass check box to EQ Preferences and implement the logic behind it.

  badescunicu

  committed
  3875241

Commits on Aug 16, 2014

• Create the aliases inside EffectsManager::addEqualizer instead of hard coding them in MixxxMainWindow::createCOAliases

  badescunicu

  committed
  b02cc8b

• Merge branch 'master' of github.com:badescunicu/mixxx into eq_rack

  badescunicu

  committed
  b04311f

Commits on Sep 4, 2014

• Fix conflicts

  badescunicu

  committed
  94b4013

Commits on Sep 5, 2014

• Fix for logarithmic control hint

  badescunicu

  committed
  40a5eb6

• Set kEffectDebugOutput to false

  badescunicu

  committed
  795e47b

• Remove commented out line from enginedeck.cpp

  badescunicu

  committed
  feb19f0

Commits on Sep 10, 2014

• Fix some coding style issues and mark a couple of strings for translate

  badescunicu

  committed
  818c873

• Remove effectprocessor.cpp because it was not used throughout the code base

  badescunicu

  committed
  e82a1ab

• Add getEQEffectRack method to EffectsManager

  badescunicu

  committed
  358e074

• Use getEQEffectRack method inside DlgPrefEQ

  badescunicu

  committed
  0343ab6

Commits on Sep 12, 2014

• Add getEQEffectRackNumber method to EffectsManager

  badescunicu

  committed
  fb70322

• Rename checkBox_bypass to CheckBoxBypass

  badescunicu

  committed
  490dcd6

• Use another approach at bypassing the EQ Rack

  Show description for e47fe35
  badescunicu

  committed
  e47fe35

• Store the effects' ids as configs instead of their names

  badescunicu

  committed
  ef107cc

Commits on Oct 15, 2014

• Merge remote-tracking branch 'upstream/master' into eq_rack2

  Show description for dadb9eb
  daschuer

  committed
  dadb9eb

• Repopulate DeckEffectSelectors

  daschuer

  committed
  c970a8c

Commits on Oct 16, 2014

• retrain the selected effect when chaning filter showAll

  daschuer

  committed
  aebed5b

Commits on Oct 17, 2014

• some refectoring in advanced to new enableWaveformEQ

  daschuer

  committed
  61d8287

Commits on Oct 18, 2014

• Added new "enableWaveformEq" CO

  daschuer

  committed
  663c42c

Commits on Oct 19, 2014

• some minor doc and style changes

  daschuer

  committed
  f158fc7

Commits on Oct 26, 2014

• Visualize the EQ Bypass in waveforms

  daschuer

  committed
  615e6d2

Commits on Nov 5, 2014

• Merge remote-tracking branch 'upstream/master' into eq_rack2

  Show description for 8860815
  daschuer

  committed
  8860815

Commits on Nov 10, 2014

• Merge remote-tracking branch 'upstream/master' into eq_rack2

  Show description for e86788f
  daschuer

  committed
  e86788f

• renamed advaced checkbox to "Fill menus with the best suited effects only"

  daschuer

  committed
  f8b09ec

Commits on Nov 14, 2014

• Shade: hide EQ Controls when no effect parameter loaded

  daschuer

  committed
  a34a668

• Shade: remove wrong tooltips from effect Knobs

  daschuer

  committed
  c145760

• Merge remote-tracking branch 'upstream/master' into eq_rack2

  Show description for a1e2600
  daschuer

  committed
  a1e2600

• Merge remote-tracking branch 'upstream/master' into eq_rack2

  Show description for 547bad5
  daschuer

  committed
  547bad5

Commits on Nov 15, 2014

• Fix EqReset on track load after merge.

  daschuer

  committed
  141825f

• EQPref: Reset everything on slotResetToDefaults

  daschuer

  committed
  061eae4

• remove not workin warning from getAvailableEffectNames() and getAvailableEQEffectNames()

  daschuer

  committed
  79ef7ba

• visualise the EQ Knobs only if a Mixing EQ is loaded

  daschuer

  committed
  5001e14

• Fixed Tests, by NULL initalise Pointers

  daschuer

  committed
  4ba6f32

• User Alias for the _loaded EQ controlls.

  Show description for 7804e38
  daschuer

  committed
  7804e38

Commits on Nov 16, 2014

• Added EffectChainSlot::getChainSlotNumber()

  daschuer

  committed
  a67c211

• EffectsManager::addEqualizer() is now read for any group

  daschuer

  committed
  26224b8

• user qDeleteAll in DlgPrefEQ::~DlgPrefEQ

  daschuer

  committed
  bf1d681

• Changed config key to EffectForGroup_[ChannelX]

  daschuer

  committed
  31848c9

• introduce kDefaultEqId and convert other macros to consts as well

  daschuer

  committed
  d80c098

• Fix WaveformEqCo value after startup

  daschuer

  committed
  f504a17

• Fix use of slotUpdate()

  daschuer

  committed
  dcb7830

• getEQEffectRackNumber() reflexs now the o based index like all othe Number functions

  daschuer

  committed
  d19f2a4

• renamed enableWaveformEQ to fliterWaveformEnable to match prefix

  daschuer

  committed
  4227f18

• fixesd bypass default

  daschuer

  committed
  a58fde4

• Introduced getEffectNamesFiltered for custom filtered effect lists

  daschuer

  committed
  e8df768

• Merge remote-tracking branch 'upstream/master' into eq_rack2

  Show description for 85a1051
  daschuer

  committed
  85a1051