Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add com.apple.security.device.audio-input entitlement on macOS #3681

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Mar 9, 2021

@Holzhaus
Copy link
Member

Holzhaus commented Mar 9, 2021

Lol, PR race condition: #3682

@Holzhaus
Copy link
Member

Holzhaus commented Mar 9, 2021

Please add some comments to clarify the distinction between the microphone and the audio-input entitlement. If you'd lazy you can just cherry pick the commit from my fork.

@Be-ing
Copy link
Contributor Author

Be-ing commented Mar 9, 2021

I actually don't know what the difference is and Apple's documentation doesn't make it clear.

@Holzhaus
Copy link
Member

Holzhaus commented Mar 9, 2021

I actually don't know what the difference is and Apple's documentation doesn't make it clear.

Check my PR, I added comments there.

@Be-ing
Copy link
Contributor Author

Be-ing commented Mar 9, 2021

I can't reproduce the bug on macOS 10.13. It might only affect later versions of macOS.

@Holzhaus
Copy link
Member

Holzhaus commented Mar 9, 2021

I can't reproduce the bug on macOS 10.13. It might only affect later versions of macOS.

Yes, the hardened runtime was introduced in macOS Mojave (10.14).

@Be-ing
Copy link
Contributor Author

Be-ing commented Mar 9, 2021

@Be-ing Be-ing merged commit bfd167c into 2.3 Mar 9, 2021
@Be-ing Be-ing deleted the macos_audio_input branch March 9, 2021 09:42
@Holzhaus
Copy link
Member

Holzhaus commented Mar 9, 2021

Please add some comments to clarify the distinction between the microphone and the audio-input entitlement. If you'd lazy you can just cherry pick the commit from my fork.

Ping! Please don't merge your own PR, especially if there are still comments from review that have not been resolved.

@Be-ing
Copy link
Contributor Author

Be-ing commented Mar 9, 2021

I disagree with your proposed comments. They don't add any information. As I said before, I don't actually know what the difference between these confusingly named entitlements are and Apple's documentation doesn't clarify, so I don't know what comment could be helpful.

@Holzhaus
Copy link
Member

Holzhaus commented Mar 9, 2021

I disagree with your proposed comments. They don't add any information. As I said before, I don't actually know what the difference between these confusingly named entitlements are and Apple's documentation doesn't clarify, so I don't know what comment could be helpful.

Yes they do. They make clear that these entitlements are for two different, independent systems that partially overlap:

  • Sandboxing
  • Hardened Runtime

You can build an app with sandboxing but without hardened runtime, with hardened runtime but without sandboxing, with both or with none of them.

Also see: https://lapcatsoftware.com/articles/hardened-runtime-sandboxing2.html

@daschuer
Copy link
Member

The missing documentation was added here: #3685
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants