-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add com.apple.security.device.audio-input entitlement on macOS #3681
Conversation
Lol, PR race condition: #3682 |
Please add some comments to clarify the distinction between the microphone and the audio-input entitlement. If you'd lazy you can just cherry pick the commit from my fork. |
I actually don't know what the difference is and Apple's documentation doesn't make it clear. |
Check my PR, I added comments there. |
I can't reproduce the bug on macOS 10.13. It might only affect later versions of macOS. |
Yes, the hardened runtime was introduced in macOS Mojave (10.14). |
Ping! Please don't merge your own PR, especially if there are still comments from review that have not been resolved. |
I disagree with your proposed comments. They don't add any information. As I said before, I don't actually know what the difference between these confusingly named entitlements are and Apple's documentation doesn't clarify, so I don't know what comment could be helpful. |
Yes they do. They make clear that these entitlements are for two different, independent systems that partially overlap:
You can build an app with sandboxing but without hardened runtime, with hardened runtime but without sandboxing, with both or with none of them.
Also see: https://lapcatsoftware.com/articles/hardened-runtime-sandboxing2.html |
The missing documentation was added here: #3685 |
fixes https://bugs.launchpad.net/mixxx/+bug/1917530