EngineSync: Merge class with BaseSyncableListener #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
approved these changes
Mar 20, 2021
Holzhaus
commented
Mar 20, 2021
Comment on lines
-12
to
-13
| // TODO(owilliams): This class is only inherited by EngineSync. It should | ||
| // be merged into that class. |
There was a problem hiding this comment.
I was confused why the functionality was split across these classes, then I found this comment.
|
Merging this now, because it makes sense and was already proposed as a TODO. LGTM |
|
this has been on my todo list forever! thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, just got rid an unnecessary base class and made some test functions private.