Shade: Fix invalid "alignment" property for LibraryBPMButton #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following command-line warnings:
Warning [Main]: QCheckBox(0x560803109c10, name="LibraryBPMButton") does not have a property named "alignment"
[...]
Warning [Main]: QCheckBox(0x560806004220, name="LibraryBPMButton") does not have a property named "alignment"
|
Seems there is no qss way to push the BPM value to the right border of the cell, so basically all those attempts can be removed from all skins. @Holzhaus wanna do it here or should I add that in #3782 ? btw align right (or align decimal points) of BPM is still open. |
ronso0
approved these changes
Apr 13, 2021
No, let's just merge this now to fix the warning (makes no visual difference on my system), and then you can make a follow-up PR if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following command-line warnings: