CMake fix passing multiple paths to libdjinterop #3787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake does not appear to pass lists of paths correctly to external projects when invoking similarly to the below, affecting builds involving libdjinterop with sources fetched from GitHub:
The above causes path separators to be replaced with whitespace. This breaks the Windows build when run from Visual Studio, where the path contains multiple elements as follows:
When these paths are set in
CMAKE_PREFIX_PATH
with semicolon delimiter, it is transformed to whitespace upon invoking the external project, meaning only the first path gets searched. Because the dependencies of libdjinterop can only be found in the second/third paths, this leads to a missing dependency error when trying to build libdjinterop.A workaround (inspired by this SO post) is to delimit the paths with something other than semicolon, which is what this PR does.