-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ENGINEPRIME feature on Debian builds #3798
Enable ENGINEPRIME feature on Debian builds #3798
Conversation
The PR has been initially created in draft mode, because I'm unsure if there is a good way to properly test this before merging. Any suggestions appreciated! |
Since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that fine.
Why is this still in draft state?
We cannot test this without merging. I don't mind if it fails, in that case we can try again or revert. |
☝️ |
@mr-smidge Please test as soon as the ppa deb is updated amd report back. |
Oh, I missed that we also build armhf. Can you also enable it on your PPA? |
Will do. There is some endian-specific stuff in libdjinterop that could do with being portable. It may work already, but needs testing. |
Builds for amd64/i386/armhf have succeeded - now awaiting them to be copied to other series and published: https://launchpad.net/~xsco/+archive/ubuntu/djinterop/+packages |
@daschuer there are now builds across i386/amd64/armhf at version Once there, what are the next steps to kick off a deb build for Mixxx to test this out? Is that something I can do myself, or is it a privileged operation? |
Looks like the nightly PPA builds have suceeded! Version |
This PR enables the
ENGINEPRIME
feature in Debian builds, using thelibdjinterop-dev
development package.The libdjinterop library is now available in the Mixxx PPA: https://launchpad.net/~mixxx/+archive/ubuntu/nightlies/+packages - provided this is available during the Debian packaging build phase, it can be built.