Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ENGINEPRIME feature on Debian builds #3798

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

mr-smidge
Copy link
Contributor

This PR enables the ENGINEPRIME feature in Debian builds, using the libdjinterop-dev development package.

The libdjinterop library is now available in the Mixxx PPA: https://launchpad.net/~mixxx/+archive/ubuntu/nightlies/+packages - provided this is available during the Debian packaging build phase, it can be built.

@mr-smidge
Copy link
Contributor Author

The PR has been initially created in draft mode, because I'm unsure if there is a good way to properly test this before merging. Any suggestions appreciated!

@uklotzde
Copy link
Contributor

Since the control.in file is only used to package Mixxx for our PPA this should be fine.

@daschuer?

@uklotzde uklotzde requested a review from daschuer April 18, 2021 19:05
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that fine.

Why is this still in draft state?

@daschuer
Copy link
Member

We cannot test this without merging. I don't mind if it fails, in that case we can try again or revert.

@Holzhaus
Copy link
Member

Holzhaus commented Apr 18, 2021

Why is this still in draft state?

The PR has been initially created in draft mode, because I'm unsure if there is a good way to properly test this before merging.

☝️

@ronso0 ronso0 marked this pull request as ready for review April 18, 2021 20:45
@ronso0 ronso0 merged commit 41ec6c7 into mixxxdj:main Apr 18, 2021
@ronso0
Copy link
Member

ronso0 commented Apr 18, 2021

@mr-smidge Please test as soon as the ppa deb is updated amd report back.

@daschuer
Copy link
Member

Oh, I missed that we also build armhf. Can you also enable it on your PPA?

@mr-smidge
Copy link
Contributor Author

Oh, I missed that we also build armhf. Can you also enable it on your PPA?

Will do. There is some endian-specific stuff in libdjinterop that could do with being portable. It may work already, but needs testing.

@mr-smidge
Copy link
Contributor Author

Builds for amd64/i386/armhf have succeeded - now awaiting them to be copied to other series and published: https://launchpad.net/~xsco/+archive/ubuntu/djinterop/+packages

@mr-smidge
Copy link
Contributor Author

@daschuer there are now builds across i386/amd64/armhf at version 0.15.2-0ubuntu2 - please could you (or anyone with suitable permissions) copy these to the Mixxx PPA?

Once there, what are the next steps to kick off a deb build for Mixxx to test this out? Is that something I can do myself, or is it a privileged operation?

@mr-smidge
Copy link
Contributor Author

Looks like the nightly PPA builds have suceeded! Version 2.4.0~alpha~pre1~git7846-0ubuntu2~main~git7846~focal was built with libdjinterop-dev as a build dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants