Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load tracks via TrackCollectionManager #3842

Merged
merged 2 commits into from
May 9, 2021
Merged

Load tracks via TrackCollectionManager #3842

merged 2 commits into from
May 9, 2021

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented May 7, 2021 •
edited
Loading

The TrackCollectionManager will soon store and provide additional configuration data like the custom tags mapping that is required as context data when loading tracks.

  • TrackCollection: Reduce visibility of functions that should not be invoked without TrackCollectionManager (see TODO comment in TrackCollection.h)
  • Use TrackCollectionManager instead of accessing the internal TrackCollection directly

No functional changes.

@uklotzde uklotzde added this to the 2.4.0 milestone May 7, 2021
@uklotzde
Load tracks via TrackCollectionManager
148315b 
The TrackCollectionManager will soon store and provide additional
configuration data like the custom tags mapping that is required
when loading tracks.
Holzhaus
Holzhaus approved these changes May 8, 2021
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, thanks. Some comments that don't block this PR, but maybe we should change this nonetheless.

src/analyzer/trackanalysisscheduler.cpp Outdated Show resolved Hide resolved
src/library/dao/autodjcratesdao.cpp Show resolved Hide resolved
src/library/dao/autodjcratesdao.cpp Show resolved Hide resolved
Holzhaus
Holzhaus approved these changes May 9, 2021
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.

@Holzhaus
Copy link
Member

Holzhaus commented May 9, 2021

Waiting for CI.

@Holzhaus Holzhaus merged commit cda903c into mixxxdj:main May 9, 2021
@uklotzde uklotzde deleted the trackcollectionmanager branch May 9, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
code quality library ui
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @Holzhaus