Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MidiOpCode/MidiOption enums with scoped enum classes #3880

Merged
merged 4 commits into from
May 30, 2021
Merged

Replace MidiOpCode/MidiOption enums with scoped enum classes #3880

merged 4 commits into from
May 30, 2021

Conversation

Holzhaus
Copy link
Member

No description provided.

@Holzhaus Holzhaus force-pushed the midi-enums branch 3 times, most recently from f3c0296 to f9e5ec8 Compare May 19, 2021 18:29
@Holzhaus
Copy link
Member Author

Ready now.

@Holzhaus Holzhaus requested a review from uklotzde May 21, 2021 22:29
uklotzde
uklotzde approved these changes May 30, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@uklotzde uklotzde merged commit 744e4bd into mixxxdj:main May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Holzhaus @uklotzde