Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkinLoader: Skip skin directory if "skin.xml" is missing #3933

Merged
merged 1 commit into from
Jun 1, 2021

Commits on Jun 1, 2021

  1. SkinLoader: Skip skin directory if "skin.xml" is missing

    This is a small fix that is useful on it's own, but also improves
    forward compatibility with the new QML skin system.
    
    If you work on a QML skin and have it configured in the settings, then
    switch to a 2.3-based branch, the skin obviously won't load. But if the
    skin directory exists (e.g. because you have unstages files in it),
    Mixxx will refuse to start at all instead of falling back to the default
    skin. The only way to fix this is editing `mixxx.cfg` by hand or
    removing the directory.
    
    This fix adds an additional check if the `skin.xml` exists, and skips
    the skin if not. That allows Mixxx to fall back to the default skin.
    Holzhaus committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    4c9eacf View commit details
    Browse the repository at this point in the history